From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/5] drivercore: add new error value for deferred probe Date: Fri, 7 Oct 2011 17:12:37 -0700 Message-ID: <20111008001237.GA30551@kroah.com> References: <1317963790-29426-1-git-send-email-manjugk@ti.com> <1317963790-29426-2-git-send-email-manjugk@ti.com> <20111007064349.GD27508@kroah.com> <32004.1318030113@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <32004.1318030113@turing-police.cc.vt.edu> Sender: linux-mmc-owner@vger.kernel.org To: Valdis.Kletnieks@vt.edu Cc: Grant Likely , "G, Manjunath Kondaiah" , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Dilan Lee , Mark Brown , Manjunath GKondaiah , Arnd Bergmann List-Id: linux-omap@vger.kernel.org On Fri, Oct 07, 2011 at 07:28:33PM -0400, Valdis.Kletnieks@vt.edu wrote= : > On Fri, 07 Oct 2011 16:12:45 MDT, Grant Likely said: > > On Fri, Oct 7, 2011 at 12:43 AM, Greg KH wrote: > > > On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah w= rote: >=20 > > >> +#define EPROBE_DEFER 517 =A0 =A0 /* restart probe again after s= ome time */ > > > > > > Can we really do this? >=20 > > According to Arnd, yes this is okay. >=20 > > > =A0Isn't this some user/kernel api here? >=20 > > > What's wrong with just "overloading" on top of an existing error = code? > > > Surely one of the other 516 types could be used here, right? >=20 > > overloading makes it really hard to find the users at a later date. >=20 > Would proposing '#define EPROBE_DEFER EAGAIN' be acceptable to everyb= ody? That > would allow overloading EAGAIN, but still make it easy to tell the us= ages apart > if we need to separate them later... Yes, please do that, it is what USB does for it's internal error code handling. greg k-h