From: Mike Frysinger <vapier@gentoo.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Mundt <lethal@linux-sh.org>,
Tony Lindgren <tony@atomide.com>,
linux-sh@vger.kernel.org, linux-omap@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] regulator: Provide dummy supply support
Date: Tue, 1 Nov 2011 13:50:14 -0400 [thread overview]
Message-ID: <201111011350.17425.vapier@gentoo.org> (raw)
In-Reply-To: <20111028224757.GG23421@pengutronix.de>
[-- Attachment #1: Type: Text/Plain, Size: 1206 bytes --]
On Friday 28 October 2011 18:47:57 Sascha Hauer wrote:
> On Fri, Oct 28, 2011 at 11:59:31PM +0200, Mark Brown wrote:
> > On Fri, Oct 28, 2011 at 10:26:58PM +0200, Sascha Hauer wrote:
> > > drivers/regulator/Makefile | 2 +-
> > > drivers/regulator/dummy-supply.c | 88
> > > +++++++++++++++++++++++++++++++++++++
> >
> > We already have a dummy regulator driver and a fixed voltage regulator
> > driver, we shouldn't be adding a third implementation of the same thing.
> > Just use the fixed voltage regulator for this.
>
> I explained in my mail why I think that the current implementation of
> the dummy regulator is not suitable for things apart from debugging.
your complaints seem to be specific to how the dummy regulator gets hooked in
and not in the specific regulator implementation. so it seems like the right
thing would be to split the kconfig knobs:
config REGULATOR_DUMMY
- bool "Provide a dummy regulator if regulator lookups fail"
+ bool "Provide a dummy regulator"
+config REGULATOR_DUMMY_FALLBACK
+ bool "Fallback to dummy regulator if lookup fails"
+ depends on REGULATOR_DUMMY
(and then obviously update the .c files accordingly)
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-01 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 20:26 [PATCH] regulator: provide dummy supply support Sascha Hauer
2011-10-28 20:26 ` [PATCH] regulator: Provide " Sascha Hauer
2011-10-28 21:59 ` Mark Brown
2011-10-28 22:47 ` Sascha Hauer
2011-10-28 23:16 ` Mike Frysinger
2011-10-29 17:42 ` Mark Brown
2011-11-01 17:50 ` Mike Frysinger [this message]
2011-11-01 18:27 ` Mark Brown
2011-11-02 10:03 ` Sascha Hauer
2011-11-02 10:41 ` Mark Brown
2011-11-02 14:29 ` Sascha Hauer
2011-10-28 21:57 ` [PATCH] regulator: provide " Mark Brown
2011-10-28 23:22 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111011350.17425.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=tony@atomide.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox