From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [RFC/PATCH] ARM: OMAP: Fix build for OMAP3 only builds Date: Wed, 2 Nov 2011 10:16:05 -0700 Message-ID: <20111102171605.GK31337@atomide.com> References: <1318421036-1498-1-git-send-email-weber@corscience.de> <4EB1398B.80901@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:59165 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755120Ab1KBRQK (ORCPT ); Wed, 2 Nov 2011 13:16:10 -0400 Content-Disposition: inline In-Reply-To: <4EB1398B.80901@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Thomas Weber Cc: "Nori, Sekhar" , Thomas Weber , "linux-omap@vger.kernel.org" , Russell King * Thomas Weber [111102 04:03]: > Am 27.10.2011 07:32, schrieb Nori, Sekhar: > > On Wed, Oct 12, 2011 at 17:33:56, Thomas Weber wrote: > >> When building for OMAP3 only I get the > >> following errors: > >> > >> In function `omap2420_init_early': > >> undefined reference to `omap2_set_globals_242x' > >> undefined reference to `omap2xxx_voltagedomains_init' > >> undefined reference to `omap242x_powerdomains_init' > >> undefined reference to `omap242x_clockdomains_init' > >> undefined reference to `omap2420_hwmod_init' > >> > >> In function `omap2430_init_early': > >> undefined reference to `omap2_set_globals_243x' > >> undefined reference to `omap2xxx_voltagedomains_init' > >> undefined reference to `omap243x_powerdomains_init' > >> undefined reference to `omap243x_clockdomains_init' > >> undefined reference to `omap2430_hwmod_init' > >> > >> In function `omap4430_init_early': > >> undefined reference to `omap2_set_globals_443x' > >> undefined reference to `omap44xx_voltagedomains_init' > >> undefined reference to `omap44xx_powerdomains_init' > >> undefined reference to `omap44xx_clockdomains_init' > >> undefined reference to `omap44xx_hwmod_init' > >> undefined reference to `omap4xxx_clk_init' > >> > >> With this patch the omapXXXX_init_early will be compiled only > >> when their SOC's are selected. > >> > >> Signed-off-by: Thomas Weber > > > > I was facing the same problem and this patch helped > > me get rid of it. > > > > Tested-by: Sekhar Nori > > > > Thanks, > > Sekhar > > > > -- > > Hello Tony, > > what is the status of this patch? > > There is also another patch fixing the same problem. > > [PATCH v2] arm: omap: Fix errors and warnings when building for one board Well looks like we got the initial DT changes merged! Only two minor patches needed for compile errors that I just posted. Will take a look at this and other fixes needed to fixes-part2 next. Tony