From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count
Date: Fri, 4 Nov 2011 15:25:59 +0000 [thread overview]
Message-ID: <20111104152559.GC28615@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A90194B0@DBDE01.ent.ti.com>
On Fri, Nov 04, 2011 at 02:26:05PM +0000, Mohammed, Afzal wrote:
> Hi Brown,
Ahem.
> On Fri, Nov 04, 2011 at 19:34:22, Mark Brown wrote:
> > On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote:
> > > if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) {
> > > pmic->desc[i].ops = &tps65910_ops_dcdc;
> > > + pmic->desc[i].n_voltages = VDD1_2_NUM_VOLTS * 3;
> > This looks suspicous - what's the * 3 about?
> Gain in voltage possible is x1, 0x2 & 0x3, I am shaky
> about this change, but voltage could be changed with this,
That doesn't really clarify things - the question is why the number of
voltages we can set is three times a constant called _NUM_VOLTS?
next prev parent reply other threads:[~2011-11-04 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:48 [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count Afzal Mohammed
2011-11-04 14:04 ` Mark Brown
2011-11-04 14:26 ` Mohammed, Afzal
2011-11-04 15:25 ` Mark Brown [this message]
2011-11-04 16:01 ` Mohammed, Afzal
2011-11-04 16:18 ` Mark Brown
2011-11-04 16:32 ` Mohammed, Afzal
2011-11-04 16:40 ` Mark Brown
2011-11-04 16:48 ` Mohammed, Afzal
2011-11-04 17:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104152559.GC28615@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=afzal@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox