Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

Mark Brown
2011-11-04T17:26:18Z

On Fri, Nov 04, 2011 at 04:48:09PM +0000, Mohammed, Afzal wrote:

> Effective voltage expression is (value1 * 12.5mV + 562.5 mV) * value2.

> In this value2 is being called as gain.

> value1 can have values from 3 to 75, both inclusive (73 steps)
> value2 can have from 1 to 3, both inclusive (3 numbers)

Right, that makes sense. It looks like you need a new constant for the
gain and the existing constant for value1 should be renamed to make it
more obvious that it's not the only part of the selector, the current
constant is confusingly named given the above.