From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count Date: Fri, 4 Nov 2011 17:26:18 +0000 Message-ID: <20111104172617.GA20002@opensource.wolfsonmicro.com> References: <1320410928-20349-1-git-send-email-afzal@ti.com> <20111104140422.GA28615@opensource.wolfsonmicro.com> <20111104152559.GC28615@opensource.wolfsonmicro.com> <20111104161855.GC28902@opensource.wolfsonmicro.com> <20111104164009.GA753@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Mohammed, Afzal" Cc: "linux-kernel@vger.kernel.org" , "Girdwood, Liam" , "sameo@linux.intel.com" , "Nori, Sekhar" , "linux-omap@vger.kernel.org" , "gg@slimlogic.co.uk" , Jorge Eduardo Candelaria List-Id: linux-omap@vger.kernel.org On Fri, Nov 04, 2011 at 04:48:09PM +0000, Mohammed, Afzal wrote: > Effective voltage expression is (value1 * 12.5mV + 562.5 mV) * value2. > In this value2 is being called as gain. > value1 can have values from 3 to 75, both inclusive (73 steps) > value2 can have from 1 to 3, both inclusive (3 numbers) Right, that makes sense. It looks like you need a new constant for the gain and the existing constant for value1 should be renamed to make it more obvious that it's not the only part of the selector, the current constant is confusingly named given the above.