From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] arm: omap2+: hwmod: fix breakage introduced by d6504acd Date: Mon, 7 Nov 2011 22:41:29 +0000 Message-ID: <20111107224129.GJ15294@n2100.arm.linux.org.uk> References: <1320688617-4543-1-git-send-email-balbi@ti.com> <20111107183208.GG15294@n2100.arm.linux.org.uk> <20111107193908.GA5059@legolas.emea.dhcp.ti.com> <20111107212707.GH15294@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:34735 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256Ab1KGWln (ORCPT ); Mon, 7 Nov 2011 17:41:43 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Felipe Balbi , Tony Lindgren , Linux OMAP Mailing List , Linux Kernel Mailing List , Linux ARM Kernel Mailing List On Mon, Nov 07, 2011 at 02:29:35PM -0700, Paul Walmsley wrote: > On Mon, 7 Nov 2011, Russell King - ARM Linux wrote: > > > Again, can never have been tested on OMAP3. > > > > Does anyone apart from me bother doing any testing what so ever on OMAP3 > > platforms? Am I the only one? > > This was fixed by > > http://www.spinics.net/lists/arm-kernel/msg143549.html > > which didn't go upstream as part of the v3.2 merge window. Ah, that patch. Which version of the patch does Tony have? The one you point at which uses IS_ERR_VALUE() and I complained about, or the version that has that fixed?