From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dist-devel@blackfin.uclinux.org
Cc: NamJae Jeon <linkinjeon@gmail.com>, Joe Perches <joe@perches.com>,
Cliff Cai <cliff.cai@analog.com>,
linux-omap@vger.kernel.org, Alex Dubov <oakad@yahoo.com>,
Nicolas Pitre <nico@fluxnic.net>,
linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Harald Welte <HaraldWelte@viatech.com>,
Bruce Chang <brucechang@via.com.tw>,
Sascha Sommer <saschasommer@freenet.de>,
linux-arm-kernel@lists.infradead.org,
Tony Olech <tony.olech@elandigitalsystems.com>,
Manuel Lauss <manuel.lauss@gmail.com>,
Pierre Ossman <pierre@ossman.eu>, Chris Ball <cjb@laptop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mmc: Logging neatening
Date: Wed, 16 Nov 2011 13:38:46 -0500 [thread overview]
Message-ID: <201111161338.53049.vapier@gentoo.org> (raw)
In-Reply-To: <CAKYAXd8_mDF68PnEnpuZZQ+O8-QmrfRpP4jv+SpHDx1juTxFGQ@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 792 bytes --]
On Tuesday 15 November 2011 20:48:05 NamJae Jeon wrote:
> 2011/11/16 Joe Perches <joe@perches.com>:
> > mci_writel(host, CTRL, SDMMC_CTRL_INT_ENABLE); /* Enable mci
> > interrupt */
> >
> > - dev_info(&pdev->dev, "DW MMC controller at irq %d, "
> > - "%d bit host data width, "
> > - "%u deep fifo\n",
> > + dev_info(&pdev->dev,
> > + "DW MMC controller at irq %d, %d bit host data width, %u deep
> > fifo\n", irq, width, fifo_size);
>
> I think that tab is needed this "DW MMC controller at irq ...." ?
looks to me like this was the only part you replied to. could you please snip
the unrelated context in the future ? no reason to include ~1700 lines of
context when you only replying to like ~10 lines.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-16 18:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 23:32 [PATCH 0/4] mmc: logging neatening and mmc_host_<level> Joe Perches
2011-11-15 23:32 ` [PATCH 1/4] mmc: Update logging style Joe Perches
2011-11-16 1:18 ` NamJae Jeon
2011-11-15 23:32 ` [PATCH 3/4] mmc: Logging neatening Joe Perches
[not found] ` <d2c1a76fea1844ae7ac3e7e17183fb39df19178e.1321398814.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-11-16 1:48 ` NamJae Jeon
2011-11-16 1:50 ` Joe Perches
2011-11-16 1:55 ` NamJae Jeon
2011-11-16 2:00 ` Joe Perches
2011-11-16 2:08 ` NamJae Jeon
2011-11-16 18:38 ` Mike Frysinger [this message]
2011-11-15 23:32 ` [PATCH 4/4] mmc: Add mmc_host_<level> logging Joe Perches
2011-11-16 0:52 ` NamJae Jeon
2011-11-16 0:57 ` Joe Perches
2011-11-16 1:14 ` NamJae Jeon
2011-11-16 1:18 ` Joe Perches
2011-11-16 5:00 ` David Brown
2011-11-16 5:31 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111161338.53049.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=HaraldWelte@viatech.com \
--cc=brucechang@via.com.tw \
--cc=cjb@laptop.org \
--cc=cliff.cai@analog.com \
--cc=joe@perches.com \
--cc=linkinjeon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=nico@fluxnic.net \
--cc=nicolas.ferre@atmel.com \
--cc=oakad@yahoo.com \
--cc=pierre@ossman.eu \
--cc=saschasommer@freenet.de \
--cc=tony.olech@elandigitalsystems.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox