From: Felipe Balbi <balbi@ti.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] cbus: Fix initialization of cached IRQ masks
Date: Fri, 18 Nov 2011 15:34:51 +0200 [thread overview]
Message-ID: <20111118133450.GD9999@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20111118113132.5baeb268@milhouse>
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
On Fri, Nov 18, 2011 at 11:31:32AM +0100, Michael Büsch wrote:
> This fixes the initialization of retu/tahvo cached IRQ masks.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
Reviewed-by: Felipe Balbi <balbi@ti.com>
>
> ---
>
> v2: lowercase
>
> Index: linux-3.1.1/drivers/cbus/retu.c
> ===================================================================
> --- linux-3.1.1.orig/drivers/cbus/retu.c 2011-11-17 23:09:26.498214061 +0100
> +++ linux-3.1.1/drivers/cbus/retu.c 2011-11-17 23:15:50.280659655 +0100
> @@ -451,7 +451,8 @@ static int __devinit retu_probe(struct p
> (rev >> 4) & 0x07, rev & 0x0f);
>
> /* Mask all RETU interrupts */
> - __retu_write_reg(retu, RETU_REG_IMR, 0xffff);
> + retu->mask = 0xffff;
> + __retu_write_reg(retu, RETU_REG_IMR, retu->mask);
>
> ret = request_threaded_irq(retu->irq, NULL, retu_irq_handler,
> IRQF_ONESHOT, "retu", retu);
> Index: linux-3.1.1/drivers/cbus/tahvo.c
> ===================================================================
> --- linux-3.1.1.orig/drivers/cbus/tahvo.c 2011-11-17 23:15:46.684674232 +0100
> +++ linux-3.1.1/drivers/cbus/tahvo.c 2011-11-17 23:15:50.280659655 +0100
> @@ -346,7 +346,8 @@ static int __devinit tahvo_probe(struct
> (rev >> 4) & 0x0f, rev & 0x0f);
>
> /* Mask all TAHVO interrupts */
> - __tahvo_write_reg(tahvo, TAHVO_REG_IMR, 0xffff);
> + tahvo->mask = 0xffff;
> + __tahvo_write_reg(tahvo, TAHVO_REG_IMR, tahvo->mask);
>
> ret = request_threaded_irq(irq, NULL, tahvo_irq_handler,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
>
> --
> Greetings, Michael.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-18 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 10:31 [PATCH v2] cbus: Fix initialization of cached IRQ masks Michael Büsch
2011-11-18 13:34 ` Felipe Balbi [this message]
2011-11-19 0:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118133450.GD9999@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=m@bues.ch \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox