From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Rajendra Nayak <rnayak@ti.com>,
grant.likely@secretlab.ca, robherring2@gmail.com,
linaro-dev@lists.linaro.org, patches@linaro.org,
tony@atomide.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, olof@lixom.net,
linux-omap@vger.kernel.org, lrg@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data
Date: Sun, 4 Dec 2011 15:54:35 +0000 [thread overview]
Message-ID: <20111204155433.GA16287@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAJuYYwRO+AS=WmQfNAe8L6Gi5Dm4VsCuVqk3X5Nb8uUYAdLnJQ@mail.gmail.com>
On Sun, Dec 04, 2011 at 06:51:23PM +0530, Thomas Abraham wrote:
> For regulators that are not turned on by bootloader, and which require
> 'apply_uV' constraint, is there any alternative for turning on the
> regulator when using dt?
If the regulator isn't software managed then always_on covers this - the
regulator core will enable any always_on regulators that haven't been
enabled already.
> /* do we need to apply the constraint voltage */
> - if (rdev->constraints->apply_uV &&
> - rdev->constraints->min_uV == rdev->constraints->max_uV) {
> + if ((rdev->constraints->apply_uV &&
> + rdev->constraints->min_uV == rdev->constraints->max_uV) ||
> + (!rdev->constraints->boot_on && rdev->constraints->always_on)) {
> ret = _regulator_do_set_voltage(rdev,
> rdev->constraints->min_uV,
> rdev->constraints->max_uV);
I'm not sure I understand the intended logic there. Voltage constraints
and enable/disable constraints are orthogonal here.
next prev parent reply other threads:[~2011-12-04 15:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 11:17 [PATCH v5 0/4] Device tree support for regulators Rajendra Nayak
[not found] ` <1321615040-13257-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-11-18 11:17 ` [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data Rajendra Nayak
2011-12-04 13:21 ` Thomas Abraham
2011-12-04 15:54 ` Mark Brown [this message]
2011-12-05 9:10 ` Thomas Abraham
2011-12-05 10:34 ` Mark Brown
2011-12-05 10:44 ` Thomas Abraham
[not found] ` <CAJuYYwSRW-=XufvHS1miO2xNANwQMZqPbt=VyPEonywnAsvVUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 10:57 ` Mark Brown
[not found] ` <20111205105733.GE11150-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-05 11:09 ` Thomas Abraham
2011-12-06 6:54 ` Rajendra Nayak
2012-05-23 17:48 ` David Brown
2011-11-18 11:17 ` [PATCH v5 2/4] regulator: adapt fixed regulator driver to dt Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 3/4] regulator: pass additional of_node to regulator_register() Rajendra Nayak
2011-12-04 9:53 ` Thomas Abraham
[not found] ` <CAJuYYwRa=AGZ+Chuj+v49EHE+bOuoCWxhmDUO35BoZK2g97FQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 7:19 ` Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 4/4] regulator: map consumer regulator based on device tree Rajendra Nayak
[not found] ` <1321615040-13257-5-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-11-23 18:44 ` Mark Brown
2011-11-23 19:01 ` [PATCH v5 0/4] Device tree support for regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111204155433.GA16287@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=rnayak@ti.com \
--cc=robherring2@gmail.com \
--cc=thomas.abraham@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).