From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: Re: [PATCH] mfd: add bq2415x charger driver Date: Tue, 6 Dec 2011 03:17:49 +0100 Message-ID: <20111206021749.GA7202@earth.universe> References: <1323124541-7590-1-git-send-email-felipe.contreras@nokia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Return-path: Received: from comu.ring0.de ([46.4.151.82]:48140 "EHLO smtp.ring0.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932811Ab1LFCSG (ORCPT ); Mon, 5 Dec 2011 21:18:06 -0500 Content-Disposition: inline In-Reply-To: <1323124541-7590-1-git-send-email-felipe.contreras@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: linux-main , linux-omap , Samuel Ortiz , Pali =?iso-8859-1?Q?Roh=E1r?= , Aliaksei Katovich , Vladimir Zapolskiy , Felipe Contreras --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Good to hear somebody is working on this :) I planned to do this myself, but didn't find any time for it. Here are some comments =66rom me: [...] > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig I would expect the driver in drivers/power. But maybe MFD is better, since the chip can also be used to power USB host? [...] > +#define BQ2415X_VOLTAGE_SCALE 20000 If I remember correctly (I read the specs some time ago), this can be configured via external resistor. So this is board specific? [...] > + bq2415x_i2c_write(cli, BQ2415X_CHG_CTL, 0x42); > + bq2415x_set_voltage(cli, 0, 4200000); > + bq2415x_set_current_limit(cli, 1800000, 1800000); So it always charges with 1.8A? Shouldn't this be dependent on the input source (e.g. 500mA from USB)? Also what's if no charger is connected at all? Apart from this I think those values should be exposed to sysfs via /sys/class/power_supply. -- Sebastian --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJO3XtNAAoJENju1/PIO/qaCQQP/jn5Zp92a7kaUss3zOEY3KOw aFz2YMwPW0OZtPS7QAKT0T2jGHn7SVbh478V6tA2y8g9lCkh3KMutBhd5FkC5dUk g2yKhnvK2R58ZjgqU5jn+4A5fDS3cf0g16Nvvj41MjQIpmA+meXZC8tYtM+7jxSg HzfvCJUYXjtfVaLDVvtCOxc/gGt2y2QTE+BUMRmHSh7olVbiaxP+pWoJsvQ9PaMP WBQM6CvEusr7AEcNkXHdKUXH7OpvOBaU5RWU/BIPpx5WITkfvSq5YBNKHGWvcpv0 wrWemnVpQWfMGJsOOLWiITwoCHLMdMEvyPM09H3Z6RbHgKMHxRR9r5YSTAu63YEM CJPgVnbvBpdCP1/sJ626gKbTbt2EmzWGJ0vUqynYc/9wE5neDOsvDY/tyP8MMg1g l8eN9N9C89aWqoxxHbBa3uaauLJtMvyW7U45/yBk+kGY1SATu9/BwwMSFEBxiZZp c8Q8KMDy5s0EULVi5sHaaiHYGbQ4tCsSJo4DBi/Y0X80idDfnBvSpmB7qI+3BxXs jdXri1OswbO5rnAbFFSz9IT22JNSoln0VFwuaeTy6FNmlEE1ts+BUUtD/vi2pWWg ugZ+MdyN84A1msbLiLJGHsksJvILIogDJlryGpc3o+7mf+/1qe1T2g5fjC85Iuo5 D0MF9Xyk+gejJhcpq0Ro =Wmry -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--