From: Tony Lindgren <tony@atomide.com>
To: Ilya Yanok <yanok@emcraft.com>
Cc: linux-omap@vger.kernel.org, wd@denx.de, dzu@denx.de, sasha_d@emcraft.com
Subject: Re: [PATCH] am35xx-emac: move generic EMAC init to separate file
Date: Wed, 7 Dec 2011 16:15:03 -0800 [thread overview]
Message-ID: <20111208001503.GV31337@atomide.com> (raw)
In-Reply-To: <1321490199-24371-1-git-send-email-yanok@emcraft.com>
* Ilya Yanok <yanok@emcraft.com> [111116 16:01]:
> AM35xx SoCs include DaVinci EMAC IP. Initialization code in
> board-am3517evm.c is pretty board independent and will work for any
> AM35xx based board so move this code to it's own file to be reused by
> other boards.
Should this be just called emac-common.c? Or is it so am35xx specific
that it won't work with others?
> + clk_add_alias(NULL, dev_name(&am35xx_emac_device.dev),
> + "emac_clk", &am35xx_emac_device.dev);
> + clk_add_alias(NULL, dev_name(&am35xx_mdio_device.dev),
> + "phy_clk", &am35xx_emac_device.dev);
Hmm after moving the code and should be a separate patch, don't
we already have these clock aliases in cloc3xxx_data.c?
Tony
next prev parent reply other threads:[~2011-12-08 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 0:36 [PATCH] am35xx-emac: move generic EMAC init to separate file Ilya Yanok
2011-12-08 0:15 ` Tony Lindgren [this message]
2011-12-14 23:46 ` Ilya Yanok
2011-12-15 9:39 ` Igor Grinberg
2011-12-15 18:43 ` Tony Lindgren
2011-12-15 21:42 ` Ilya Yanok
2011-12-16 6:13 ` Paul Walmsley
2011-12-20 22:31 ` Ilya Yanok
2011-12-21 1:38 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208001503.GV31337@atomide.com \
--to=tony@atomide.com \
--cc=dzu@denx.de \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).