From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly Date: Thu, 8 Dec 2011 16:40:44 +0200 Message-ID: <20111208144044.GA25415@xps8300> References: <20111207193141.GG31337@atomide.com> <1323287816-2809-1-git-send-email-felipe.contreras@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1323287816-2809-1-git-send-email-felipe.contreras@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Contreras Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tony Lindgren , Russell King , Kalle Jokiniemi , Anton Vorontsov List-Id: linux-omap@vger.kernel.org Hi Felipe, On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > From: Heikki Krogerus I would prefer that you change this so this is from you, like it actually is. You can mention me in the commit message if you like. > Without this USB networking doesn't work as the link is never detected. What this changes is, it leaves the transceiver powered by default instead of setting it into power off mode. So not only USB networking is affected by this. If isp1704_charger is not enabled with RX51, USB does not work at all. Please change the comment. Thanks, -- heikki