From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 4/7] amp/omap: add a remoteproc driver Date: Thu, 8 Dec 2011 09:01:14 -0800 Message-ID: <20111208170114.GZ31337@atomide.com> References: <1319536106-25802-1-git-send-email-ohad@wizery.com> <1319536106-25802-5-git-send-email-ohad@wizery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ohad Ben-Cohen Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, Brian Swetland , Arnd Bergmann , Grant Likely , Rusty Russell , Russell King , Greg KH , Stephen Boyd List-Id: linux-omap@vger.kernel.org * Ohad Ben-Cohen [111207 23:26]: > Hi Tony, >=20 > On Tue, Oct 25, 2011 at 11:48 AM, Ohad Ben-Cohen wr= ote: > > Add a remoteproc driver for OMAP4, so we can boot the dual-M3 "Duca= ti" > > and DSP subsystems. > > > > Use the omap_device_* API to control the hardware state, and utiliz= e > > the OMAP mailbox to interrupt the remote processor when a new messa= ge > > is pending (the mailbox payload is used to tell it which virtqueue = was > > the message placed in). > > > > Conversely, when an inbound mailbox message arrives, tell the remot= eproc > > core which virtqueue is triggered. > > > > Later we will also use the mailbox payload to signal omap-specific > > events like remote crashes (which will be used to trigger remotepro= c > > recovery) and power management transitions. At that point we will a= lso > > extend the remoteproc core to support this. > > > > Based on (but now quite far from) work done by Fernando Guzman Lugo > > and Hari Kanigeri . > > > > Designed with Brian Swetland . > > > > Signed-off-by: Ohad Ben-Cohen > > Cc: Brian Swetland > > Cc: Arnd Bergmann > > Cc: Grant Likely > > Cc: Tony Lindgren > > Cc: Russell King > > Cc: Rusty Russell > > Cc: Andrew Morton > > Cc: Greg KH > > Cc: Stephen Boyd > > --- > > =C2=A0arch/arm/plat-omap/include/plat/remoteproc.h | =C2=A0 56 ++++= ++ > > =C2=A0drivers/amp/remoteproc/Kconfig =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | =C2=A0 21 +++ > > =C2=A0drivers/amp/remoteproc/Makefile =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| =C2=A0 =C2=A04 +- > > =C2=A0drivers/amp/remoteproc/omap_remoteproc.c =C2=A0 =C2=A0 | =C2=A0= 248 ++++++++++++++++++++++++++ > > =C2=A0drivers/amp/remoteproc/omap_remoteproc.h =C2=A0 =C2=A0 | =C2=A0= 69 +++++++ > > =C2=A05 files changed, 397 insertions(+), 1 deletions(-) > > =C2=A0create mode 100644 arch/arm/plat-omap/include/plat/remoteproc= =2Eh > > =C2=A0create mode 100644 drivers/amp/remoteproc/omap_remoteproc.c > > =C2=A0create mode 100644 drivers/amp/remoteproc/omap_remoteproc.h >=20 > I'm about to add this to linux-next (minus the 'amp' wording); can I > please have your Acked-by for this (at least for the plat-omap change= ) ? The platform init code looks OK to me. Please also start considering how to do the DT bindings for it. For patches 4 & 5: Acked-by: Tony Lindgren