From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly Date: Mon, 12 Dec 2011 11:44:45 -0800 Message-ID: <20111212194445.GG32251@atomide.com> References: <20111207193141.GG31337@atomide.com> <1323287816-2809-1-git-send-email-felipe.contreras@gmail.com> <20111208144044.GA25415@xps8300> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Felipe Contreras Cc: Heikki Krogerus , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Kalle Jokiniemi , Anton Vorontsov List-Id: linux-omap@vger.kernel.org * Felipe Contreras [111208 11:52]: > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus wrote: > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > >> From: Heikki Krogerus > > > > I would prefer that you change this so this is from you, like it > > actually is. You can mention me in the commit message if you like. > > Well, you came with the fix, I just typed it down, but as you wish :) > > >> Without this USB networking doesn't work as the link is never detected. > > > > What this changes is, it leaves the transceiver powered by default > > instead of setting it into power off mode. So not only USB networking > > is affected by this. If isp1704_charger is not enabled with RX51, USB > > does not work at all. Please change the comment. > > I've updated the patch. Sorry what's the deal with this one? Is this the one to use or is there some other patch? Tony