From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly Date: Tue, 13 Dec 2011 21:00:57 +0100 Message-ID: <20111213200057.GA2965@earth.universe> References: <20111207193141.GG31337@atomide.com> <1323287816-2809-1-git-send-email-felipe.contreras@gmail.com> <20111208144044.GA25415@xps8300> <20111212194445.GG32251@atomide.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Return-path: Content-Disposition: inline In-Reply-To: <20111212194445.GG32251@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Felipe Contreras , Heikki Krogerus , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Kalle Jokiniemi , Anton Vorontsov List-Id: linux-omap@vger.kernel.org --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2011 at 11:44:45AM -0800, Tony Lindgren wrote: > * Felipe Contreras [111208 11:52]: > > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus wrot= e: > > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > > >> From: Heikki Krogerus > > > > > > I would prefer that you change this so this is from you, like it > > > actually is. You can mention me in the commit message if you like. > >=20 > > Well, you came with the fix, I just typed it down, but as you wish :) > >=20 > > >> Without this USB networking doesn't work as the link is never detect= ed. > > > > > > What this changes is, it leaves the transceiver powered by default > > > instead of setting it into power off mode. So not only USB networking > > > is affected by this. If isp1704_charger is not enabled with RX51, USB > > > does not work at all. Please change the comment. > >=20 > > I've updated the patch. >=20 > Sorry what's the deal with this one? Is this the one to use or is there > some other patch? I can confirm, that USB on RX51 does not work with 3.1 mainline kernel and applying this patch (There's a v2 with fixed Author under [0]) results in working USB support. [0] http://www.spinics.net/lists/linux-omap/msg61217.html -- Sebastian --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJO5675AAoJENju1/PIO/qafSUP/i5/AbIdskhNV+6ivSuZm025 tZ/UjriT9X/rHvkJGjTgBTYfO6mageQy4b3GyuoKPsWUNDge6XWtmtYhCFlsX6oq IsAqtCo3RkXmfKZGqiET+tqO6R0Ytf4BUA92dynQBP95THaFqTUXSuAwAEARLBPe JCndERxecQ8f/2d+dwAWoZBE6/t2fooohI63vNTe7pctXBZelAkKS14OI0x6oyHf IQBK7fagRTKC7rUU6iHNi4HYCfc/JjQcWchEKb1sfMsgKkMjcTPA3ie5nLml2D/i TUIOLXt7kLs1Z+LIqStXlbL+Xkqq+0Qpdsx5Kb77HJMi1PC6PBytKnNmF/1dZhYU V0C2sNF25EwXS7EWA1UrYBzmA6itv8GBkvdOEoF0ysuykw9etO64953L4IFAv9Ra G3nt+Y0sVmK0w8sHqtM/kZLB/2u29CejuROVY5lJGFfgMQSIbGoMw/DDrz6c1wfN YOdRO9TxPJLzISHNVKIWQLtdos9Yi2ru29I+KCmBDCi3cfvuofHF4drdOc4Zawwy uABp0cdAF7ALNLT8WgUPIDKMLqYr4nsLY2gfFxajfrpL89ZLUxfv+1KE5P95ZwRh ZA8+nlL2UZqVDfHh9WGZlBtPL/G0u5URnWXLMo4TKV7MBnvvEYZJ3Z+oUQl2a/oW BIuq3XQRSFPkMvbwBT4k =jwPg -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--