From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Heikki Krogerus <krohei@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Kalle Jokiniemi <kalle.jokiniemi@nokia.com>,
Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly
Date: Tue, 13 Dec 2011 13:55:01 -0800 [thread overview]
Message-ID: <20111213215501.GU32251@atomide.com> (raw)
In-Reply-To: <CAMP44s301iWcReReqScJw+N1pQ4=g8D8hZKOV3wEX-qN0_gRQQ@mail.gmail.com>
* Felipe Contreras <felipe.contreras@gmail.com> [111213 11:33]:
> On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
> >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> >> >> From: Heikki Krogerus <krohei@gmail.com>
> >> >
> >> > I would prefer that you change this so this is from you, like it
> >> > actually is. You can mention me in the commit message if you like.
> >>
> >> Well, you came with the fix, I just typed it down, but as you wish :)
> >>
> >> >> Without this USB networking doesn't work as the link is never detected.
> >> >
> >> > What this changes is, it leaves the transceiver powered by default
> >> > instead of setting it into power off mode. So not only USB networking
> >> > is affected by this. If isp1704_charger is not enabled with RX51, USB
> >> > does not work at all. Please change the comment.
> >>
> >> I've updated the patch.
> >
> > Sorry what's the deal with this one? Is this the one to use or is there
> > some other patch?
>
> Yeap, there's v2 of this one:
> 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com
OK, thanks applying into fixes.
Tony
prev parent reply other threads:[~2011-12-13 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111207193141.GG31337@atomide.com>
2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-08 14:40 ` Heikki Krogerus
2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras
2011-12-10 8:37 ` Sebastian Reichel
2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-12 19:44 ` Tony Lindgren
2011-12-13 20:00 ` Sebastian Reichel
2011-12-13 20:05 ` Felipe Contreras
2011-12-13 21:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213215501.GU32251@atomide.com \
--to=tony@atomide.com \
--cc=cbouatmailru@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=kalle.jokiniemi@nokia.com \
--cc=krohei@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).