[PATCH] omap: rx51: initialize isp1704 properly

[PATCH] omap: rx51: initialize isp1704 properly

[Felipe Contreras]

From: Heikki Krogerus <krohei@gmail.com>

Without this USB networking doesn't work as the link is never detected.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index a1d0257..faac1fc 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -193,7 +193,7 @@ static struct platform_device rx51_charger_device = {
 static void __init rx51_charger_init(void)
 {
 	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
-		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
+		GPIOF_OUT_INIT_HIGH, "isp1704_reset"));
 
 	platform_device_register(&rx51_charger_device);
 }
-- 
1.7.8.rc1.14.g248db

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Heikki Krogerus]

Hi Felipe,

On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> From: Heikki Krogerus <krohei@gmail.com>

I would prefer that you change this so this is from you, like it
actually is. You can mention me in the commit message if you like.

> Without this USB networking doesn't work as the link is never detected.

What this changes is, it leaves the transceiver powered by default
instead of setting it into power off mode. So not only USB networking
is affected by this. If isp1704_charger is not enabled with RX51, USB
does not work at all. Please change the comment.

Thanks,

-- 
heikki

[PATCH v2] omap: rx51: fix USB

[Felipe Contreras]

From: Felipe Contreras <felipe.contreras@gmail.com>

The transceiver should be powered on by default, otherwise USB doesn't
work at all.

All kernels after v3.0 are affected.

Cc: stable@kernel.org
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index ba1aa07..c15c5c9 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -193,7 +193,7 @@ static struct platform_device rx51_charger_device = {
 static void __init rx51_charger_init(void)
 {
 	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
-		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
+		GPIOF_OUT_INIT_HIGH, "isp1704_reset"));
 
 	platform_device_register(&rx51_charger_device);
 }
-- 
1.7.8.rc3.17.gf56ef1

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Felipe Contreras]

On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
>> From: Heikki Krogerus <krohei@gmail.com>
>
> I would prefer that you change this so this is from you, like it
> actually is. You can mention me in the commit message if you like.

Well, you came with the fix, I just typed it down, but as you wish :)

>> Without this USB networking doesn't work as the link is never detected.
>
> What this changes is, it leaves the transceiver powered by default
> instead of setting it into power off mode. So not only USB networking
> is affected by this. If isp1704_charger is not enabled with RX51, USB
> does not work at all. Please change the comment.

I've updated the patch.

Cheers.

-- 
Felipe Contreras

Re: [PATCH v2] omap: rx51: fix USB

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

On Thu, Dec 08, 2011 at 10:23:00PM +0200, Felipe Contreras wrote:
> The transceiver should be powered on by default, otherwise USB doesn't
> work at all.
> 
> All kernels after v3.0 are affected.

I tested this patch successfully on 3.1 mainline kernel.
You can add this if you want:

Reviewed-by: Sebastian Reichel <sre@debian.org>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Tony Lindgren]

* Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> >> From: Heikki Krogerus <krohei@gmail.com>
> >
> > I would prefer that you change this so this is from you, like it
> > actually is. You can mention me in the commit message if you like.
> 
> Well, you came with the fix, I just typed it down, but as you wish :)
> 
> >> Without this USB networking doesn't work as the link is never detected.
> >
> > What this changes is, it leaves the transceiver powered by default
> > instead of setting it into power off mode. So not only USB networking
> > is affected by this. If isp1704_charger is not enabled with RX51, USB
> > does not work at all. Please change the comment.
> 
> I've updated the patch.

Sorry what's the deal with this one? Is this the one to use or is there
some other patch?

Tony

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

On Mon, Dec 12, 2011 at 11:44:45AM -0800, Tony Lindgren wrote:
> * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
> > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> > >> From: Heikki Krogerus <krohei@gmail.com>
> > >
> > > I would prefer that you change this so this is from you, like it
> > > actually is. You can mention me in the commit message if you like.
> > 
> > Well, you came with the fix, I just typed it down, but as you wish :)
> > 
> > >> Without this USB networking doesn't work as the link is never detected.
> > >
> > > What this changes is, it leaves the transceiver powered by default
> > > instead of setting it into power off mode. So not only USB networking
> > > is affected by this. If isp1704_charger is not enabled with RX51, USB
> > > does not work at all. Please change the comment.
> > 
> > I've updated the patch.
> 
> Sorry what's the deal with this one? Is this the one to use or is there
> some other patch?

I can confirm, that USB on RX51 does not work with 3.1 mainline
kernel and applying this patch (There's a v2 with fixed Author under
[0]) results in working USB support.

[0] http://www.spinics.net/lists/linux-omap/msg61217.html

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Felipe Contreras]

On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
>> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
>> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
>> >> From: Heikki Krogerus <krohei@gmail.com>
>> >
>> > I would prefer that you change this so this is from you, like it
>> > actually is. You can mention me in the commit message if you like.
>>
>> Well, you came with the fix, I just typed it down, but as you wish :)
>>
>> >> Without this USB networking doesn't work as the link is never detected.
>> >
>> > What this changes is, it leaves the transceiver powered by default
>> > instead of setting it into power off mode. So not only USB networking
>> > is affected by this. If isp1704_charger is not enabled with RX51, USB
>> > does not work at all. Please change the comment.
>>
>> I've updated the patch.
>
> Sorry what's the deal with this one? Is this the one to use or is there
> some other patch?

Yeap, there's v2 of this one:
1323375780-13190-1-git-send-email-felipe.contreras@nokia.com

Cheers.

-- 
Felipe Contreras

Re: [PATCH] omap: rx51: initialize isp1704 properly

[Tony Lindgren]

* Felipe Contreras <felipe.contreras@gmail.com> [111213 11:33]:
> On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
> >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> >> >> From: Heikki Krogerus <krohei@gmail.com>
> >> >
> >> > I would prefer that you change this so this is from you, like it
> >> > actually is. You can mention me in the commit message if you like.
> >>
> >> Well, you came with the fix, I just typed it down, but as you wish :)
> >>
> >> >> Without this USB networking doesn't work as the link is never detected.
> >> >
> >> > What this changes is, it leaves the transceiver powered by default
> >> > instead of setting it into power off mode. So not only USB networking
> >> > is affected by this. If isp1704_charger is not enabled with RX51, USB
> >> > does not work at all. Please change the comment.
> >>
> >> I've updated the patch.
> >
> > Sorry what's the deal with this one? Is this the one to use or is there
> > some other patch?
> 
> Yeap, there's v2 of this one:
> 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com

OK, thanks applying into fixes.

Tony