* [PATCH] omap: rx51: initialize isp1704 properly [not found] <20111207193141.GG31337@atomide.com> @ 2011-12-07 19:56 ` Felipe Contreras 2011-12-08 14:40 ` Heikki Krogerus 0 siblings, 1 reply; 9+ messages in thread From: Felipe Contreras @ 2011-12-07 19:56 UTC (permalink / raw) To: linux-omap Cc: linux-arm-kernel, linux-kernel, Tony Lindgren, Russell King, Kalle Jokiniemi, Anton Vorontsov, Heikki Krogerus, Felipe Contreras From: Heikki Krogerus <krohei@gmail.com> Without this USB networking doesn't work as the link is never detected. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index a1d0257..faac1fc 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -193,7 +193,7 @@ static struct platform_device rx51_charger_device = { static void __init rx51_charger_init(void) { WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO, - GPIOF_OUT_INIT_LOW, "isp1704_reset")); + GPIOF_OUT_INIT_HIGH, "isp1704_reset")); platform_device_register(&rx51_charger_device); } -- 1.7.8.rc1.14.g248db ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras @ 2011-12-08 14:40 ` Heikki Krogerus 2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras 2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras 0 siblings, 2 replies; 9+ messages in thread From: Heikki Krogerus @ 2011-12-08 14:40 UTC (permalink / raw) To: Felipe Contreras Cc: linux-omap, linux-arm-kernel, linux-kernel, Tony Lindgren, Russell King, Kalle Jokiniemi, Anton Vorontsov Hi Felipe, On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > From: Heikki Krogerus <krohei@gmail.com> I would prefer that you change this so this is from you, like it actually is. You can mention me in the commit message if you like. > Without this USB networking doesn't work as the link is never detected. What this changes is, it leaves the transceiver powered by default instead of setting it into power off mode. So not only USB networking is affected by this. If isp1704_charger is not enabled with RX51, USB does not work at all. Please change the comment. Thanks, -- heikki ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] omap: rx51: fix USB 2011-12-08 14:40 ` Heikki Krogerus @ 2011-12-08 20:23 ` Felipe Contreras 2011-12-10 8:37 ` Sebastian Reichel 2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras 1 sibling, 1 reply; 9+ messages in thread From: Felipe Contreras @ 2011-12-08 20:23 UTC (permalink / raw) To: linux-omap Cc: linux-arm-kernel, linux-kernel, Tony Lindgren, Kalle Jokiniemi, Heikki Krogerus, Russell King, Anton Vorontsov, Felipe Contreras, stable From: Felipe Contreras <felipe.contreras@gmail.com> The transceiver should be powered on by default, otherwise USB doesn't work at all. All kernels after v3.0 are affected. Cc: stable@kernel.org Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index ba1aa07..c15c5c9 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -193,7 +193,7 @@ static struct platform_device rx51_charger_device = { static void __init rx51_charger_init(void) { WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO, - GPIOF_OUT_INIT_LOW, "isp1704_reset")); + GPIOF_OUT_INIT_HIGH, "isp1704_reset")); platform_device_register(&rx51_charger_device); } -- 1.7.8.rc3.17.gf56ef1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] omap: rx51: fix USB 2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras @ 2011-12-10 8:37 ` Sebastian Reichel 0 siblings, 0 replies; 9+ messages in thread From: Sebastian Reichel @ 2011-12-10 8:37 UTC (permalink / raw) To: Felipe Contreras Cc: linux-omap, linux-arm-kernel, linux-kernel, Tony Lindgren, Kalle Jokiniemi, Heikki Krogerus, Russell King, Anton Vorontsov, Felipe Contreras, stable [-- Attachment #1: Type: text/plain, Size: 359 bytes --] On Thu, Dec 08, 2011 at 10:23:00PM +0200, Felipe Contreras wrote: > The transceiver should be powered on by default, otherwise USB doesn't > work at all. > > All kernels after v3.0 are affected. I tested this patch successfully on 3.1 mainline kernel. You can add this if you want: Reviewed-by: Sebastian Reichel <sre@debian.org> -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-08 14:40 ` Heikki Krogerus 2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras @ 2011-12-08 20:23 ` Felipe Contreras 2011-12-12 19:44 ` Tony Lindgren 1 sibling, 1 reply; 9+ messages in thread From: Felipe Contreras @ 2011-12-08 20:23 UTC (permalink / raw) To: Heikki Krogerus Cc: linux-omap, linux-arm-kernel, linux-kernel, Tony Lindgren, Russell King, Kalle Jokiniemi, Anton Vorontsov On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: >> From: Heikki Krogerus <krohei@gmail.com> > > I would prefer that you change this so this is from you, like it > actually is. You can mention me in the commit message if you like. Well, you came with the fix, I just typed it down, but as you wish :) >> Without this USB networking doesn't work as the link is never detected. > > What this changes is, it leaves the transceiver powered by default > instead of setting it into power off mode. So not only USB networking > is affected by this. If isp1704_charger is not enabled with RX51, USB > does not work at all. Please change the comment. I've updated the patch. Cheers. -- Felipe Contreras ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras @ 2011-12-12 19:44 ` Tony Lindgren 2011-12-13 20:00 ` Sebastian Reichel 2011-12-13 20:05 ` Felipe Contreras 0 siblings, 2 replies; 9+ messages in thread From: Tony Lindgren @ 2011-12-12 19:44 UTC (permalink / raw) To: Felipe Contreras Cc: Heikki Krogerus, linux-omap, linux-arm-kernel, linux-kernel, Russell King, Kalle Jokiniemi, Anton Vorontsov * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]: > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > >> From: Heikki Krogerus <krohei@gmail.com> > > > > I would prefer that you change this so this is from you, like it > > actually is. You can mention me in the commit message if you like. > > Well, you came with the fix, I just typed it down, but as you wish :) > > >> Without this USB networking doesn't work as the link is never detected. > > > > What this changes is, it leaves the transceiver powered by default > > instead of setting it into power off mode. So not only USB networking > > is affected by this. If isp1704_charger is not enabled with RX51, USB > > does not work at all. Please change the comment. > > I've updated the patch. Sorry what's the deal with this one? Is this the one to use or is there some other patch? Tony ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-12 19:44 ` Tony Lindgren @ 2011-12-13 20:00 ` Sebastian Reichel 2011-12-13 20:05 ` Felipe Contreras 1 sibling, 0 replies; 9+ messages in thread From: Sebastian Reichel @ 2011-12-13 20:00 UTC (permalink / raw) To: Tony Lindgren Cc: Felipe Contreras, Heikki Krogerus, linux-omap, linux-arm-kernel, linux-kernel, Russell King, Kalle Jokiniemi, Anton Vorontsov [-- Attachment #1: Type: text/plain, Size: 1330 bytes --] On Mon, Dec 12, 2011 at 11:44:45AM -0800, Tony Lindgren wrote: > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]: > > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > > >> From: Heikki Krogerus <krohei@gmail.com> > > > > > > I would prefer that you change this so this is from you, like it > > > actually is. You can mention me in the commit message if you like. > > > > Well, you came with the fix, I just typed it down, but as you wish :) > > > > >> Without this USB networking doesn't work as the link is never detected. > > > > > > What this changes is, it leaves the transceiver powered by default > > > instead of setting it into power off mode. So not only USB networking > > > is affected by this. If isp1704_charger is not enabled with RX51, USB > > > does not work at all. Please change the comment. > > > > I've updated the patch. > > Sorry what's the deal with this one? Is this the one to use or is there > some other patch? I can confirm, that USB on RX51 does not work with 3.1 mainline kernel and applying this patch (There's a v2 with fixed Author under [0]) results in working USB support. [0] http://www.spinics.net/lists/linux-omap/msg61217.html -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-12 19:44 ` Tony Lindgren 2011-12-13 20:00 ` Sebastian Reichel @ 2011-12-13 20:05 ` Felipe Contreras 2011-12-13 21:55 ` Tony Lindgren 1 sibling, 1 reply; 9+ messages in thread From: Felipe Contreras @ 2011-12-13 20:05 UTC (permalink / raw) To: Tony Lindgren Cc: Heikki Krogerus, linux-omap, linux-arm-kernel, linux-kernel, Russell King, Kalle Jokiniemi, Anton Vorontsov On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote: > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]: >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: >> >> From: Heikki Krogerus <krohei@gmail.com> >> > >> > I would prefer that you change this so this is from you, like it >> > actually is. You can mention me in the commit message if you like. >> >> Well, you came with the fix, I just typed it down, but as you wish :) >> >> >> Without this USB networking doesn't work as the link is never detected. >> > >> > What this changes is, it leaves the transceiver powered by default >> > instead of setting it into power off mode. So not only USB networking >> > is affected by this. If isp1704_charger is not enabled with RX51, USB >> > does not work at all. Please change the comment. >> >> I've updated the patch. > > Sorry what's the deal with this one? Is this the one to use or is there > some other patch? Yeap, there's v2 of this one: 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com Cheers. -- Felipe Contreras ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] omap: rx51: initialize isp1704 properly 2011-12-13 20:05 ` Felipe Contreras @ 2011-12-13 21:55 ` Tony Lindgren 0 siblings, 0 replies; 9+ messages in thread From: Tony Lindgren @ 2011-12-13 21:55 UTC (permalink / raw) To: Felipe Contreras Cc: Heikki Krogerus, linux-omap, linux-arm-kernel, linux-kernel, Russell King, Kalle Jokiniemi, Anton Vorontsov * Felipe Contreras <felipe.contreras@gmail.com> [111213 11:33]: > On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote: > > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]: > >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > >> >> From: Heikki Krogerus <krohei@gmail.com> > >> > > >> > I would prefer that you change this so this is from you, like it > >> > actually is. You can mention me in the commit message if you like. > >> > >> Well, you came with the fix, I just typed it down, but as you wish :) > >> > >> >> Without this USB networking doesn't work as the link is never detected. > >> > > >> > What this changes is, it leaves the transceiver powered by default > >> > instead of setting it into power off mode. So not only USB networking > >> > is affected by this. If isp1704_charger is not enabled with RX51, USB > >> > does not work at all. Please change the comment. > >> > >> I've updated the patch. > > > > Sorry what's the deal with this one? Is this the one to use or is there > > some other patch? > > Yeap, there's v2 of this one: > 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com OK, thanks applying into fixes. Tony ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-12-13 21:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20111207193141.GG31337@atomide.com>
2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-08 14:40 ` Heikki Krogerus
2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras
2011-12-10 8:37 ` Sebastian Reichel
2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-12 19:44 ` Tony Lindgren
2011-12-13 20:00 ` Sebastian Reichel
2011-12-13 20:05 ` Felipe Contreras
2011-12-13 21:55 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).