From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support Date: Wed, 14 Dec 2011 13:55:13 +0000 Message-ID: <20111214135513.GC2568@linaro.org> References: <1323862781-3465-1-git-send-email-dave.martin@linaro.org> <1323862781-3465-5-git-send-email-dave.martin@linaro.org> <4EE8A69C.40304@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:45960 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755231Ab1LNNzU (ORCPT ); Wed, 14 Dec 2011 08:55:20 -0500 Content-Disposition: inline In-Reply-To: <4EE8A69C.40304@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org, Anton Vorontsov , Barry Song , Catalin Marinas , Colin Cross , Haojian Zhuang , John Linn , Kukjin Kim , Linus Walleij , linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org, Magnus Damm , Paul Mundt , Pawel Moll , Sascha Hauer , Shawn Guo , Tony Lindgren , Will Deacon On Wed, Dec 14, 2011 at 07:37:32AM -0600, Rob Herring wrote: > > On 12/14/2011 05:39 AM, Dave Martin wrote: > > If running in the Normal World on a TrustZone-enabled SoC, Linux > > does not have complete control over the L2 cache controller > > configuration. The kernel cannot work reliably on such platforms > > without the l2x0 cache support code built in. > > > > This patch unconditionally enables l2x0 support for the Highbank > > SoC. > > > > Thanks to Rob Herring for this suggestion. [1] > > > > Signed-off-by: Dave Martin > > > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html > > Doesn't this need to be above the SOB? Otherwise: You may be right ... certainly I see no reason _not_ to change it. So I'll change it. > > Acked-by: Rob Herring Thanks ---Dave