From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] am35xx-emac: move generic EMAC init to separate file Date: Thu, 15 Dec 2011 10:43:43 -0800 Message-ID: <20111215184342.GT32251@atomide.com> References: <1321490199-24371-1-git-send-email-yanok@emcraft.com> <20111208001503.GV31337@atomide.com> <4EE93564.3010006@emcraft.com> <4EE9C057.6010204@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:38085 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759162Ab1LOSnu (ORCPT ); Thu, 15 Dec 2011 13:43:50 -0500 Content-Disposition: inline In-Reply-To: <4EE9C057.6010204@compulab.co.il> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Igor Grinberg Cc: Ilya Yanok , linux-omap@vger.kernel.org, wd@denx.de, dzu@denx.de, sasha_d@emcraft.com, Paul Walmsley * Igor Grinberg [111215 01:07]: > Hi Ilya > > On 12/15/11 01:46, Ilya Yanok wrote: > > Hi Tony, > > > > On 08.12.2011 04:15, Tony Lindgren wrote: > >>> AM35xx SoCs include DaVinci EMAC IP. Initialization code in > >>> board-am3517evm.c is pretty board independent and will work for any > >>> AM35xx based board so move this code to it's own file to be reused by > >>> other boards. > >> > >> Should this be just called emac-common.c? Or is it so am35xx specific > >> that it won't work with others? > > > > Uh.. I'm not sure but I thought that EMAC is present only on am35xx SoCs... OK, maybe just do a quick check on that so we don't end up moving the platform init code around again in few months? > >>> + clk_add_alias(NULL, dev_name(&am35xx_emac_device.dev), > >>> + "emac_clk", &am35xx_emac_device.dev); > >>> + clk_add_alias(NULL, dev_name(&am35xx_mdio_device.dev), > >>> + "phy_clk", &am35xx_emac_device.dev); > >> > >> Hmm after moving the code and should be a separate patch, don't > >> we already have these clock aliases in cloc3xxx_data.c? > > > > No, we have > > CLK("davinci_emac", "emac_clk"...) and > > CLK("davinci_emac", "phy_clk"...) > > while drivers want ("davinci_emac", NULL) and ("davinci_mdio", NULL). > > > > Probably we have to fix the clock definitions instead of adding the aliases. > > > > So, should I post this as a separate patch? > > If it comes to that question, Cc Paul... Yes please do that as a separate patch. Thanks, TOny