Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Yegor Yefremov <yegor_sub1@visionsystems.de>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: GPMC: fix device size setup
Date: Fri, 20 Jan 2012 08:25:47 -0800	[thread overview]
Message-ID: <20120120162546.GO22818@atomide.com> (raw)
In-Reply-To: <4F199017.80506@visionsystems.de>

* Yegor Yefremov <yegor_sub1@visionsystems.de> [120120 07:29]:
> following statement can only change device size from 8-bit(0) to 16-bit(1),
> but not vice versa:
> 
> regval |= GPMC_CONFIG1_DEVICESIZE(wval);
> 
> so as this field has 1 reserved bit, that could be used in future,
> just clear both bits and then OR with the desired value

Looks like a valid fix to me. Care to repost it with linux-arm-kernel
mailing list also Cc'd so I can apply it into my fixes branch?

Thanks,

Tony
 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  arch/arm/mach-omap2/gpmc.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> Index: b/arch/arm/mach-omap2/gpmc.c
> ===================================================================
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -528,7 +528,13 @@
>  
>  	case GPMC_CONFIG_DEV_SIZE:
>  		regval  = gpmc_cs_read_reg(cs, GPMC_CS_CONFIG1);
> +
> +		/* clear 2 target bits */
> +		regval &= ~GPMC_CONFIG1_DEVICESIZE(3);
> +
> +		/* set the proper value */
>  		regval |= GPMC_CONFIG1_DEVICESIZE(wval);
> +
>  		gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, regval);
>  		break;
>  
> 

      reply	other threads:[~2012-01-20 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 16:02 GPMC: fix device size setup Yegor Yefremov
2012-01-20 16:25 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120120162546.GO22818@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=yegor_sub1@visionsystems.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox