linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jean Pihet <jean.pihet@newoldbits.com>,
	Govindraj <govindraj.ti@gmail.com>, Kevin Hilman <khilman@ti.com>,
	Paul Walmsley <paul@pwsan.com>,
	t-kristo@ti.com,
	linux-omap mailing list <linux-omap@vger.kernel.org>,
	Joe Woodward <jw@terrafix.co.uk>
Subject: Re: PM(?) problems on v3.3-rc1 on OMAP3
Date: Sun, 22 Jan 2012 22:11:32 +1100	[thread overview]
Message-ID: <20120122221132.32bd4d44@notabene.brown> (raw)
In-Reply-To: <1327071609.1921.82.camel@deskari>

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Fri, 20 Jan 2012 17:00:09 +0200 Tomi Valkeinen <tomi.valkeinen@ti.com>
wrote:


> Hmm, So CPU_IDLE is also about other power domains than mpu? What does
> it do? The CONFIG_CPU_IDLE help text doesn't say much.

On OMAP3x, CPU_IDLE is about the MPU and CORE power domains .. and about PER
to some extent I think.

Different CPU_IDLE states put one or both of MPU and CORE into lower power
states (RET or OFF).  If a domain is turned off, then the code restores stuff
afterwards.

But CPU_IDLE also does stuff with clocks, and I think this is where the issue
is.

I modified my kernel to refuse any CPU_IDLE state where MPU or CORE were
anything but ON - so only C1 and C2 were allowed.
I still had problems with DSS SYNC.

I then modified the C2 state so that it didn't allow the clocks to
auto-idle.  This is the main difference between C1 and C2 I think.

i.e. in omap3_enter_idle() in cpuidle34xx.c, I enforced the

		pwrdm_for_each_clkdm(mpu_pd, _cpuidle_deny_idle);
		pwrdm_for_each_clkdm(core_pd, _cpuidle_deny_idle);

and 

		pwrdm_for_each_clkdm(mpu_pd, _cpuidle_allow_idle);
		pwrdm_for_each_clkdm(core_pd, _cpuidle_allow_idle);

loops for C1 - they are normally only active for C1.

This allowed DSS to work fine.  It also removed my issues with HDQ.

This code disables the auto-idling of some clocks ... not entirely sure of
the details.

So it seems that it isn't a low power state but rather some clock being
allowed to turn off which is the problem.

I guess I could selective try denying idle on each clock domain until I find
the one that is the problem..

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2012-01-22 11:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 10:33 PM(?) problems on v3.3-rc1 on OMAP3 Tomi Valkeinen
2012-01-20 10:49 ` Govindraj
2012-01-20 11:07   ` Tomi Valkeinen
2012-01-20 11:21     ` Govindraj
2012-01-20 12:32       ` Jean Pihet
2012-01-20 12:44         ` Govindraj
2012-01-21  7:39       ` Paul Walmsley
2012-01-21  7:38     ` Paul Walmsley
2012-01-20 11:56 ` Govindraj
2012-01-20 12:01   ` Tomi Valkeinen
2012-01-20 12:34     ` Jean Pihet
2012-01-20 12:40       ` Tomi Valkeinen
2012-01-20 13:36         ` Jean Pihet
2012-01-20 15:00           ` Tomi Valkeinen
2012-01-22 11:11             ` NeilBrown [this message]
2012-01-23  8:53               ` Tomi Valkeinen
2012-01-23  9:04                 ` Paul Walmsley
2012-01-23  9:24                   ` Tomi Valkeinen
2012-01-23  9:31                     ` Paul Walmsley
2012-01-23 10:48                       ` Tomi Valkeinen
2012-01-23 11:02                         ` Paul Walmsley
2012-01-23 11:06                           ` Tomi Valkeinen
2012-01-24 10:39                   ` Tomi Valkeinen
2012-01-20 12:45     ` Govindraj
2012-01-20 12:47   ` Shubhrajyoti
2012-01-21  7:35 ` Paul Walmsley
2012-01-21  7:47 ` Paul Walmsley
2012-01-21 15:57   ` Tomi Valkeinen
2012-01-21 20:46     ` NeilBrown
2012-01-23  8:25       ` Tomi Valkeinen
2012-01-21 20:47     ` Paul Walmsley
2012-01-22 11:11       ` Valkeinen, Tomi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120122221132.32bd4d44@notabene.brown \
    --to=neilb@suse.de \
    --cc=govindraj.ti@gmail.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=jw@terrafix.co.uk \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).