From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?V=EDctor_M=2E_J=E1quez_L=2E?= Subject: Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler Date: Tue, 31 Jan 2012 12:19:52 +0100 Message-ID: <20120131111952.GB19973@lit.local.igalia.com> References: <20120131080543.GA3294@mwanda> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Return-path: Content-Disposition: inline In-Reply-To: <20120131080543.GA3294@mwanda> Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter Cc: Omar Ramirez Luna , Greg Kroah-Hartman , Armando Uribe , devel@driverdev.osuosl.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote: > On Tue, Jan 31, 2012 at 12:12:20AM +0100, V=EDctor Manuel J=E1quez Leal w= rote: > > Silence the warning when compiling drv_interface.c > >=20 > > Signed-off-by: V=EDctor Manuel J=E1quez Leal >=20 > What does the compiler warn about here? Normally you would cut and > paste the warning into the commit message. But at least give us a > hint. >=20 > You could also reformat that printk so the message is on one line. >=20 > dev_dbg(bridge, > "%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags= %lx\n", > __func__, filp, offset, vma->vm_start, vma->vm_end, > vma->vm_page_prot, vma->vm_flags); Ok. I'll do it. I have a doubt about the process in this case: if this is the only modification request, should I resend all the patch set, or just this one? Thanks vmjl >=20 > regards, > dan carpenter >=20 >=20 --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8nzlgACgkQUOuBUQZqwFIdHgCaA3zHuAfqmX9QG01t2UY/k0LN WlEAnjx8bPEoAJeMxvtc39e6FYvJJEhU =ieHk -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--