From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap
Date: Tue, 31 Jan 2012 21:43:39 +0300 [thread overview]
Message-ID: <20120131184338.GO3356@mwanda> (raw)
In-Reply-To: <CAB-zwWg9iudV7o5opYHOMHo8HN9EGB+n0f=mAHQCNWZovHrdvQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Tue, Jan 31, 2012 at 12:19:00PM -0600, Ramirez Luna, Omar wrote:
> On Tue, Jan 31, 2012 at 2:21 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Mon, Jan 30, 2012 at 07:20:18PM -0600, Omar Ramirez Luna wrote:
> >> This structure is still used after it has been freed, since it
> >> is being allocated in probe, calls to free it have been moved to
> >> module's remove routine.
> >>
> >> This should fix the follwoing messages when attempting to remove the
> >> module:
> >> drv_get_first_dev_extension: Failed to retrieve the object handle
> >> drv_get_first_dev_extension: Failed to retrieve the object handle
> >> drv_destroy: Failed to store DRV object
> >> mgr_destroy: Failed to store MGR object
> >>
> >
> > So this is only triggered when you do an rmmod to remove the module?
>
> Yes.
>
How often do people rmmod things on a production system? Hopefully,
never right?
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-31 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 1:20 [PATCH 0/2] staging: tidspbridge: memory leak fixes Omar Ramirez Luna
2012-01-31 1:20 ` [PATCH 1/2] staging: tidspbridge: fix bridge_open memory leaks Omar Ramirez Luna
2012-01-31 8:17 ` Dan Carpenter
2012-01-31 18:09 ` Omar Ramirez Luna
2012-01-31 18:40 ` Dan Carpenter
2012-01-31 1:20 ` [PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap Omar Ramirez Luna
2012-01-31 8:21 ` Dan Carpenter
2012-01-31 18:19 ` Ramirez Luna, Omar
2012-01-31 18:43 ` Dan Carpenter [this message]
2012-01-31 19:39 ` Felipe Contreras
2012-02-01 6:58 ` Dan Carpenter
2012-02-01 7:27 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131184338.GO3356@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).