From: Greg KH <gregkh@suse.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-omap@vger.kernel.org,
Felipe Contreras <felipe.contreras@nokia.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Jiri Kosina <jkosina@suse.cz>,
Randy Dunlap <rdunlap@xenotime.net>,
"Justin P. Mattock" <justinmattock@gmail.com>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: tidspbridge: enable watchdog by default
Date: Tue, 31 Jan 2012 17:12:39 -0800 [thread overview]
Message-ID: <20120201011239.GA797@suse.de> (raw)
In-Reply-To: <1328058094-28483-1-git-send-email-felipe.contreras@gmail.com>
On Wed, Feb 01, 2012 at 03:01:32AM +0200, Felipe Contreras wrote:
> From: Felipe Contreras <felipe.contreras@nokia.com>
>
> The public images have it enabled, it's safer, and we get rid of this
> warning:
>
> WARNING: at arch/arm/mach-omap2/omap_l3_smx.c:162 omap3_l3_app_irq+0x114/0x15c()
> In-band Error seen by IVA_SS at address 0
> Modules linked in: bridgedriver(C+) mailbox_mach mailbox ipv6 g_ether
> [<c0012848>] (unwind_backtrace+0x0/0xec) from [<c002e760>] (warn_slowpath_common+0x4c/0x64)
> [<c002e760>] (warn_slowpath_common+0x4c/0x64) from [<c002e7f8>] (warn_slowpath_fmt+0x2c/0x3c)
> [<c002e7f8>] (warn_slowpath_fmt+0x2c/0x3c) from [<c00217c8>] (omap3_l3_app_irq+0x114/0x15c)
> [<c00217c8>] (omap3_l3_app_irq+0x114/0x15c) from [<c0059844>] (handle_irq_event_percpu+0x28/0x174)
> [<c0059844>] (handle_irq_event_percpu+0x28/0x174) from [<c00599b8>] (handle_irq_event+0x28/0x38)
> [<c00599b8>] (handle_irq_event+0x28/0x38) from [<c005b8d0>] (handle_level_irq+0xb8/0xe0)
> [<c005b8d0>] (handle_level_irq+0xb8/0xe0) from [<c0059598>] (generic_handle_irq+0x28/0x30)
> [<c0059598>] (generic_handle_irq+0x28/0x30) from [<c000e62c>] (handle_IRQ+0x60/0x84)
> [<c000e62c>] (handle_IRQ+0x60/0x84) from [<c000d334>] (__irq_svc+0x34/0x80)
> [<c000d334>] (__irq_svc+0x34/0x80) from [<c0015804>] (v7_dma_inv_range+0x34/0x48)
> [<c0015804>] (v7_dma_inv_range+0x34/0x48) from [<c00129ec>] (dma_cache_maint_page+0x2c/0x34)
> [<c00129ec>] (dma_cache_maint_page+0x2c/0x34) from [<c0012a34>] (___dma_page_dev_to_cpu+0x24/0x68)
> [<c0012a34>] (___dma_page_dev_to_cpu+0x24/0x68) from [<c0012b50>] (dma_unmap_sg+0x40/0x64)
> [<c0012b50>] (dma_unmap_sg+0x40/0x64) from [<c019fba4>] (omap_hsmmc_post_req+0x3c/0x48)
> [<c019fba4>] (omap_hsmmc_post_req+0x3c/0x48) from [<c01932f4>] (mmc_post_req+0x18/0x1c)
> [<c01932f4>] (mmc_post_req+0x18/0x1c) from [<c019535c>] (mmc_start_req+0xd4/0xec)
> [<c019535c>] (mmc_start_req+0xd4/0xec) from [<c019d330>] (mmc_blk_issue_rw_rq+0x64/0x244)
> [<c019d330>] (mmc_blk_issue_rw_rq+0x64/0x244) from [<c019d7bc>] (mmc_blk_issue_rq+0x2ac/0x2cc)
> [<c019d7bc>] (mmc_blk_issue_rq+0x2ac/0x2cc) from [<c019e1c0>] (mmc_queue_thread+0x8c/0xf8)
> [<c019e1c0>] (mmc_queue_thread+0x8c/0xf8) from [<c0044c10>] (kthread+0x84/0x8c)
> [<c0044c10>] (kthread+0x84/0x8c) from [<c000e694>] (kernel_thread_exit+0x0/0x8)
> ---[ end trace 5dec1c8d7857375d ]---
>
> Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
> ---
> drivers/staging/tidspbridge/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig
> index 21a559e..614e974 100644
> --- a/drivers/staging/tidspbridge/Kconfig
> +++ b/drivers/staging/tidspbridge/Kconfig
> @@ -61,6 +61,7 @@ config TIDSPBRIDGE_CACHE_LINE_CHECK
> config TIDSPBRIDGE_WDT3
> bool "Enable watchdog timer"
> depends on TIDSPBRIDGE
> + default y
Nothing is ever default y, sorry, I can't accept this.
next prev parent reply other threads:[~2012-02-01 1:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 1:01 [PATCH] staging: tidspbridge: enable watchdog by default Felipe Contreras
2012-02-01 1:12 ` Greg KH [this message]
2012-02-01 1:37 ` Felipe Contreras
2012-02-01 3:22 ` Justin P. Mattock
2012-02-01 8:11 ` Felipe Contreras
2012-02-01 20:22 ` Ramirez Luna, Omar
2012-02-01 3:44 ` Greg KH
2012-02-01 7:26 ` Felipe Contreras
2012-02-09 17:35 ` Greg KH
2012-02-09 18:41 ` Felipe Contreras
2012-02-09 18:43 ` Felipe Contreras
2012-02-09 18:59 ` Greg KH
2012-02-09 23:30 ` Felipe Contreras
2012-02-10 0:45 ` Ramirez Luna, Omar
2012-02-10 5:18 ` Greg KH
2012-02-10 15:35 ` Justin P. Mattock
2012-02-10 16:05 ` Felipe Contreras
2012-02-10 16:14 ` Justin P. Mattock
2012-02-10 16:16 ` Greg KH
2012-02-10 16:29 ` Felipe Contreras
2012-02-10 16:16 ` Felipe Contreras
2012-02-10 17:48 ` Greg KH
2012-02-14 1:12 ` Ramirez Luna, Omar
2012-02-10 18:00 ` Dan Carpenter
2012-02-10 19:42 ` Felipe Contreras
2012-02-10 20:35 ` Dan Carpenter
2012-02-10 20:43 ` Felipe Contreras
[not found] ` <CAB-zwWhSoiMNVGQ=u=6-Umte-AaP9Qih8QMJFTyk8pjXaXysLg@mail.gmail.com>
2012-02-11 23:03 ` Felipe Contreras
2012-02-14 1:06 ` Ramirez Luna, Omar
2012-02-14 16:23 ` Felipe Contreras
2012-02-15 2:56 ` Ramirez Luna, Omar
2012-02-15 9:43 ` Víctor M. Jáquez L.
2012-02-15 11:41 ` Felipe Contreras
2012-02-15 12:02 ` Víctor M. Jáquez L.
2012-02-15 22:32 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201011239.GA797@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.contreras@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=jkosina@suse.cz \
--cc=justinmattock@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).