From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Date: Wed, 8 Feb 2012 15:46:54 -0800 Message-ID: <20120208234654.GC16877@atomide.com> References: <20120208163546.GA15849@n2100.arm.linux.org.uk> <20120208183333.GA29796@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:44396 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754853Ab2BHXq4 (ORCPT ); Wed, 8 Feb 2012 18:46:56 -0500 Content-Disposition: inline In-Reply-To: <20120208183333.GA29796@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Tony Lindgren [120208 10:02]: > * Russell King - ARM Linux [120208 08:05]: > > This is better than Kevin's earlier patch because of the descriptive > error: > > Acked-by: Tony Lindgren Hmm looks like the patch from Ahilash that Kevin queued has the also a test for missing uv_to_vsel: if (!voltdm->pmic || !voltdm->pmic->uv_to_vsel) So there seems to be more to it than what Russell's patch is doing. Regards, Tony