From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH] staging: tidspbridge: enable watchdog by default Date: Fri, 10 Feb 2012 08:14:13 -0800 Message-ID: <20120210081413.7c2df65bc5e33fbf444cf6bf@gmail.com> References: <1328058094-28483-1-git-send-email-felipe.contreras@gmail.com> <20120201011239.GA797@suse.de> <20120201034445.GA2979@kroah.com> <20120209173528.GA31726@kroah.com> <20120209185923.GB10284@kroah.com> <20120210051849.GE1565@kroah.com> <20120210073554.e9047c25c3fff71028f03fb2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:60934 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752939Ab2BJQOT convert rfc822-to-8bit (ORCPT ); Fri, 10 Feb 2012 11:14:19 -0500 Received: by yenm8 with SMTP id m8so1546055yen.19 for ; Fri, 10 Feb 2012 08:14:18 -0800 (PST) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: Greg KH , "Ramirez Luna, Omar" , "open list:STAGING SUBSYSTEM" , Jiri Kosina , Felipe Contreras , linux-omap@vger.kernel.org On Fri, 10 Feb 2012 18:05:59 +0200 =46elipe Contreras wrote: > On Fri, Feb 10, 2012 at 5:35 PM, Justin P. Mattock > wrote: > > On Thu, 9 Feb 2012 21:18:49 -0800 > > Greg KH wrote: > > > >> On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote= : > >> > Hi, > >> > > >> > On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras > >> > wrote: > >> > >> Again, I'm totally confused as to _WHY_ this needs to be y. =A0= What is > >> > >> causing this oops without it? =A0If an oops is happening, the= n shouldn't > >> > >> this be a strict dependancy? =A0Why allow it to be disabled a= t all if it > >> > >> can break your box if you don't enable it? > >> > > > >> > > It's not an oops, it's a warning, and again, it depends on the > >> > > firmware being used. We don't have control over that, and we h= ave no > >> > > way to detect if this feature is there. It's up to the user. > >> > > >> > I have been thinking more into it, how about looking for a WDT s= ymbol > >> > inside the baseimage to decide whether to turn ON/OFF WDT3, this= would > >> > mean that the code is always compiled in, but the decision to tu= rn it > >> > on/off is made at runtime. > >> > >> I totally don't understand, why not just silence the warning prope= rly > >> then? > >> > >> I fail to understand why this warning happens, why it depends on t= he > >> firmware, and why you can't detect it at runtime to not do it. =A0= And how > >> it all ties into a kconfig option... > >> > >> confused, > >> > >> greg k-h > > > > so there are _two_ issues that need to be fixed here: > > > > 1) the warning fix. > > > > 2) the whole default y thing that Mr. Torvalds is talking about. > > (the first fix(in my mind)would need to go first before anything el= se) > > > > Now reading through, greg had mentioned something about dependency,= so if this is just dependency then add the proper > > Kconfig option, but if this is more than just a _dependency_ then s= omebody(who knows this code)is going to > > have to supply the proper fix for the warning(my C skills only take= me so far!) > > > > below is my go at sending a _dependency_ fix for this, but could be= totally wrong.. > > > > From 5c7ad6c00d051d5444474007cdbecdf14bf3d0cb Mon Sep 17 00:00:00 2= 001 > > From: "Justin P. Mattock" > > Date: Fri, 10 Feb 2012 07:19:45 -0800 > > Subject: [PATCH] Add dependency TIDSBRIDGE_WDT3 to TIDSBRIDGE. > > > > This would add the missing _dependency_ to tidsbridge to prevent a = warning from happening. > > > > Note: my Kconfig skills are not the greatest so the below may or ma= y not work. > > I can't test this because I dont have the hardware. >=20 > Your patch *always* turns on TIDSPBRIDGE_WDT3, which is not what we > want. Depending on the firmware, some people might want it off. >=20 > Basically, right now on the typical firmware, people have to either > manually turn TIDSPBRIDGE_WDT3 on, or they will see the warning. >=20 > Cheers. >=20 > --=20 > Felipe Contreras ahh!! I see..=20 then maybe it needs be something like what omar had suggested, or maybe= even some=20 dmi_system_id(but the kernel has to many of those). --=20 Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html