Re: [PATCH] staging: tidspbridge: enable watchdog by default

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Feb 10, 2012 at 06:05:59PM +0200, Felipe Contreras wrote:
> > From 5c7ad6c00d051d5444474007cdbecdf14bf3d0cb Mon Sep 17 00:00:00 2001
> > From: "Justin P. Mattock" <justinmattock@gmail.com>
> > Date: Fri, 10 Feb 2012 07:19:45 -0800
> > Subject: [PATCH] Add dependency TIDSBRIDGE_WDT3 to TIDSBRIDGE.
> >
> > This would add the missing _dependency_ to tidsbridge to prevent a warning from happening.
> >
> > Note: my Kconfig skills are not the greatest so the below may or may not work.
> > I can't test this because I dont have the hardware.
> 
> Your patch *always* turns on TIDSPBRIDGE_WDT3, which is not what we
> want. Depending on the firmware, some people might want it off.

What firmware?  Why not document this properly somewhere in the help
entries?  Why not detect this automatically in the kernel based on the
firmware version?

> Basically, right now on the typical firmware, people have to either
> manually turn TIDSPBRIDGE_WDT3 on, or they will see the warning.

So, for the "typical" firmware, you do want this on, so the patch makes
sense.

How about the code be fixed so that it doesn't generate this type of
warning when using the "typical" firmware, instead of having to rely on
confusing Kconfig entries.

Still confused,

greg k-h