From: Tony Lindgren <tony@atomide.com>
To: Matt Porter <matt@ohporter.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap: board-omap3evm: add required smsc911x regulators
Date: Fri, 10 Feb 2012 09:40:47 -0800 [thread overview]
Message-ID: <20120210174046.GQ1426@atomide.com> (raw)
In-Reply-To: <1328738812-26755-1-git-send-email-mporter@ti.com>
* Matt Porter <matt@ohporter.com> [120208 13:35]:
> This fixes smsc911x support on omap3evm that has been broken since
> the smsc911x driver was updated to require the existence of vdd33a
> and vddvario supplies.
Great. Few comments:
1. Could you please include the smsc911x commit and subject here too
so it clearly shows the regression?
2. Also, why don't you add this fixed regulator to gpmc-smsc911.c?
That way it gets fixed for other too, like zoom2/3.
Regards,
Tony
next prev parent reply other threads:[~2012-02-10 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 22:06 [PATCH] omap: board-omap3evm: add required smsc911x regulators Matt Porter
2012-02-10 17:40 ` Tony Lindgren [this message]
2012-02-10 18:50 ` Matt Porter
2012-02-10 22:53 ` Tony Lindgren
2012-02-13 16:44 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210174046.GQ1426@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@ohporter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).