Re: [PATCH 1/2] mfd: omap-usb-host: Remove magic numbers for dev dma mask

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Wed, Feb 15, 2012 at 03:53:33PM +0530, Govindraj.R wrote:
> From: "Govindraj.R" <govindraj.raja@ti.com>
> 
> Remove the hardcoded magic values for dma mask and use the dma
> mask macros available.
> 
> CC: Felipe Balbi <balbi@ti.com>
> CC: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
> ---
>  drivers/mfd/omap-usb-host.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 68ac2c5..3109b0a 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -170,7 +170,7 @@ struct usbhs_hcd_omap {
>  /*-------------------------------------------------------------------------*/
>  
>  const char usbhs_driver_name[] = USBHS_DRIVER_NAME;
> -static u64 usbhs_dmamask = ~(u32)0;
> +static u64 usbhs_dmamask = DMA_BIT_MASK(32);
>  
>  /*-------------------------------------------------------------------------*/
>  
> @@ -223,7 +223,7 @@ static struct platform_device *omap_usbhs_alloc_child(const char *name,
>  	}
>  
>  	child->dev.dma_mask		= &usbhs_dmamask;
> -	child->dev.coherent_dma_mask	= 0xffffffff;
> +	child->dev.coherent_dma_mask	= DMA_BIT_MASK(32);

while at that, you could use dma_set_coherent_mask();

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]