From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/3] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins Date: Thu, 16 Feb 2012 08:35:59 -0800 Message-ID: <20120216163558.GB15692@atomide.com> References: <20120215182355.18884.18682.stgit@kaulin.local> <20120215182825.18884.40972.stgit@kaulin.local> <4F3CD460.7000306@ti.com> <4F3CD6CE.1090201@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:40876 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753278Ab2BPQgG (ORCPT ); Thu, 16 Feb 2012 11:36:06 -0500 Content-Disposition: inline In-Reply-To: <4F3CD6CE.1090201@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: linux-arm-kernel@lists.infradead.org, Russell King , linux-omap@vger.kernel.org * Rajendra Nayak [120216 01:42]: > On Thursday 16 February 2012 03:33 PM, Rajendra Nayak wrote: > >better still, I think we should just populate them statically in > >omap2_hsmmc_info struct above, so omap_hsmmc_init() takes care > >of it already. > > I just tried this and it seems to work... > > --- > arch/arm/mach-omap2/board-omap3beagle.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/arch/arm/mach-omap2/board-omap3beagle.c > =================================================================== > --- linux-2.6.orig/arch/arm/mach-omap2/board-omap3beagle.c > 2012-02-16 15:38:47.046933403 +0530 > +++ linux-2.6/arch/arm/mach-omap2/board-omap3beagle.c 2012-02-16 > 15:40:17.355349064 +0530 > @@ -253,6 +253,7 @@ > .mmc = 1, > .caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA, > .gpio_wp = -EINVAL, > + .gpio_cd = OMAP_MAX_GPIO_LINES + 0, > .deferred = true, > }, > {} /* Terminator */ Would be nice to avoid the hard coded gpio numbering for the external chips though.. Tony