From: Tony Lindgren <tony@atomide.com>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: linux-omap@vger.kernel.org, Syed Mohammed Khasim <khasim@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Philip Oberstaller <philip.oberstaller@septentrio.com>
Subject: Re: [PATCH] OMAP3 EVM: remove out-of-bounds array access of gpio_leds.
Date: Tue, 21 Feb 2012 14:48:24 -0800 [thread overview]
Message-ID: <20120221224824.GT18185@atomide.com> (raw)
In-Reply-To: <1329122122-5804-1-git-send-email-arnout@mind.be>
* Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> [120213 00:04]:
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> The omap3evm BSP enables a GPIO LED on the twl4030 chip. However,
> the static gpio_leds array doesn't have an entry for it. This is
> most likely a copy-and-paste error, because it has been in there
> since the first commit of the omap3evm BSP (53c5ec31).
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Please CC me, I'm not on the list.
>
> Since I don't have access to an OMAP3EVM board or schematics, I
> couldn't actually test if my fix is correct. I discovered the error
> because I'm using this BSP for an AM37xEVM board - which has the
> LED connected to a different GPIO. It works on the AM37xEVM board
> if I replace the assignment with the correct GPIO number (8).
Thanks, applying it into fixes.
Regards,
Tony
prev parent reply other threads:[~2012-02-21 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 8:35 [PATCH] OMAP3 EVM: remove out-of-bounds array access of gpio_leds Arnout Vandecappelle (Essensium/Mind)
2012-02-21 22:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221224824.GT18185@atomide.com \
--to=tony@atomide.com \
--cc=arnout@mind.be \
--cc=khasim@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=philip.oberstaller@septentrio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).