Latest OMAP randconfig build error

Latest OMAP randconfig build error

[Russell King - ARM Linux]

arch/arm/mach-omap2/mailbox.c: In function 'omap2_mbox_probe':
arch/arm/mach-omap2/mailbox.c:354: error: 'omap2_mboxes' undeclared (first use in this function)
arch/arm/mach-omap2/mailbox.c:354: error: (Each undeclared identifier is reported only once
arch/arm/mach-omap2/mailbox.c:354: error: for each function it appears in.)

There's also these warnings:

arch/arm/mach-omap2/omap-wakeupgen.c:181: warning: 'wakeupgen_irqmask_all' defined but not used

WARNING: arch/arm/mach-omap2/built-in.o(.text+0x7878): Section mismatch in reference from the function sr_dev_init() to the function .init.text:sr_set_nvalues()
The function sr_dev_init() references
the function __init sr_set_nvalues().
This is often because sr_dev_init lacks a __init
annotation or the annotation of sr_set_nvalues is wrong.

Config is at the usual place.

Re: Latest OMAP randconfig build error

[Ohad Ben-Cohen]

+ Tony, Suman

On Wed, Feb 22, 2012 at 10:51 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> arch/arm/mach-omap2/mailbox.c: In function 'omap2_mbox_probe':
> arch/arm/mach-omap2/mailbox.c:354: error: 'omap2_mboxes' undeclared (first use in this function)
> arch/arm/mach-omap2/mailbox.c:354: error: (Each undeclared identifier is reported only once
> arch/arm/mach-omap2/mailbox.c:354: error: for each function it appears in.)

The below should trivially solve this, but I wonder if there was any
other merit in explicitly using CONFIG_SOC_OMAP2420 there (any
different between 2420 and 2430 in that respect ?).

diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 609ea2d..e61d275 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -258,7 +258,7 @@ struct omap_mbox mbox_dsp_info = {
 struct omap_mbox *omap3_mboxes[] = { &mbox_dsp_info, NULL };
 #endif

-#if defined(CONFIG_SOC_OMAP2420)
+#if defined(CONFIG_ARCH_OMAP2)
 /* IVA */
 static struct omap_mbox2_priv omap2_mbox_iva_priv = {
 	.tx_fifo = {

Re: Latest OMAP randconfig build error

[Tony Lindgren]

* Ohad Ben-Cohen <ohad@wizery.com> [120222 01:30]:
> + Tony, Suman
> 
> On Wed, Feb 22, 2012 at 10:51 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > arch/arm/mach-omap2/mailbox.c: In function 'omap2_mbox_probe':
> > arch/arm/mach-omap2/mailbox.c:354: error: 'omap2_mboxes' undeclared (first use in this function)
> > arch/arm/mach-omap2/mailbox.c:354: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-omap2/mailbox.c:354: error: for each function it appears in.)
> 
> The below should trivially solve this, but I wonder if there was any
> other merit in explicitly using CONFIG_SOC_OMAP2420 there (any
> different between 2420 and 2430 in that respect ?).
> 
> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> index 609ea2d..e61d275 100644
> --- a/arch/arm/mach-omap2/mailbox.c
> +++ b/arch/arm/mach-omap2/mailbox.c
> @@ -258,7 +258,7 @@ struct omap_mbox mbox_dsp_info = {
>  struct omap_mbox *omap3_mboxes[] = { &mbox_dsp_info, NULL };
>  #endif
> 
> -#if defined(CONFIG_SOC_OMAP2420)
> +#if defined(CONFIG_ARCH_OMAP2)
>  /* IVA */
>  static struct omap_mbox2_priv omap2_mbox_iva_priv = {
>  	.tx_fifo = {

2430 is like omap3 for the mailbox. So the code we have seems
wrong trying to initialize it like 2420 mailbox. So we either
need a new entry for omap2430_mboxes[], or should just bail
out from the probe for 2430 for the fix.

Regards,

Tony

Re: Latest OMAP randconfig build error

[Ramirez Luna, Omar]

On Wed, Feb 22, 2012 at 11:58 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Ohad Ben-Cohen <ohad@wizery.com> [120222 01:30]:
>> + Tony, Suman
>>
>> On Wed, Feb 22, 2012 at 10:51 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > arch/arm/mach-omap2/mailbox.c: In function 'omap2_mbox_probe':
>> > arch/arm/mach-omap2/mailbox.c:354: error: 'omap2_mboxes' undeclared (first use in this function)
>> > arch/arm/mach-omap2/mailbox.c:354: error: (Each undeclared identifier is reported only once
>> > arch/arm/mach-omap2/mailbox.c:354: error: for each function it appears in.)
>>
>> The below should trivially solve this, but I wonder if there was any
>> other merit in explicitly using CONFIG_SOC_OMAP2420 there (any
>> different between 2420 and 2430 in that respect ?).
>>
>> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
>> index 609ea2d..e61d275 100644
>> --- a/arch/arm/mach-omap2/mailbox.c
>> +++ b/arch/arm/mach-omap2/mailbox.c
>> @@ -258,7 +258,7 @@ struct omap_mbox mbox_dsp_info = {
>>  struct omap_mbox *omap3_mboxes[] = { &mbox_dsp_info, NULL };
>>  #endif
>>
>> -#if defined(CONFIG_SOC_OMAP2420)
>> +#if defined(CONFIG_ARCH_OMAP2)
>>  /* IVA */
>>  static struct omap_mbox2_priv omap2_mbox_iva_priv = {
>>       .tx_fifo = {
>
> 2430 is like omap3 for the mailbox. So the code we have seems
> wrong trying to initialize it like 2420 mailbox. So we either
> need a new entry for omap2430_mboxes[], or should just bail
> out from the probe for 2430 for the fix.

Yes, current code tries to configure both mboxes in a 2430, however it
shouldn't be assigning an irq line for the iva mbox, and any request
for iva mbox should fail due to that.

Code is wrong to register both in 2430 though.

Regards,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest OMAP randconfig build error

[Ohad Ben-Cohen]

On Wed, Feb 22, 2012 at 7:58 PM, Tony Lindgren <tony@atomide.com> wrote:
> 2430 is like omap3 for the mailbox.

Gotcha, thanks.

This one below isn't pretty, but it should satisfy all build
permutations and still be correct hw-wise.

If it looks good to you I'll submit it properly.

diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 609ea2d..6f0f228 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -281,8 +281,14 @@ static struct omap_mbox mbox_iva_info = {
 	.ops	= &omap2_mbox_ops,
 	.priv	= &omap2_mbox_iva_priv,
 };
+#endif

-struct omap_mbox *omap2_mboxes[] = { &mbox_dsp_info, &mbox_iva_info, NULL };
+#if defined(CONFIG_ARCH_OMAP2)
+struct omap_mbox *omap2_mboxes[] = { &mbox_dsp_info,
+#if defined(CONFIG_SOC_OMAP2420)
+					&mbox_iva_info,
+#endif
+					NULL };
 #endif

 #if defined(CONFIG_ARCH_OMAP4)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest OMAP randconfig build error

[Russell King - ARM Linux]

On Wed, Feb 22, 2012 at 09:55:56PM +0200, Ohad Ben-Cohen wrote:
> On Wed, Feb 22, 2012 at 7:58 PM, Tony Lindgren <tony@atomide.com> wrote:
> > 2430 is like omap3 for the mailbox.
> 
> Gotcha, thanks.
> 
> This one below isn't pretty, but it should satisfy all build
> permutations and still be correct hw-wise.
> 
> If it looks good to you I'll submit it properly.
> 
> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> index 609ea2d..6f0f228 100644
> --- a/arch/arm/mach-omap2/mailbox.c
> +++ b/arch/arm/mach-omap2/mailbox.c
> @@ -281,8 +281,14 @@ static struct omap_mbox mbox_iva_info = {
>  	.ops	= &omap2_mbox_ops,
>  	.priv	= &omap2_mbox_iva_priv,
>  };
> +#endif
> 
> -struct omap_mbox *omap2_mboxes[] = { &mbox_dsp_info, &mbox_iva_info, NULL };
> +#if defined(CONFIG_ARCH_OMAP2)
> +struct omap_mbox *omap2_mboxes[] = { &mbox_dsp_info,
> +#if defined(CONFIG_SOC_OMAP2420)
> +					&mbox_iva_info,
> +#endif
> +					NULL };

Better would be:

+#ifdef CONFIG_ARCH_OMAP2
+struct omap_mbox *omap2_mboxes[] = {
+	&mbox_dsp_info,
+#ifdef CONFIG_SOC_OMAP2420
+	&mbox_iva_info,
+#endif
+	NULL
+};
 #endif

There's no point in typing any more than you have to with #if defined().
The only place where using #if defined() makes sense is if you want to
subsequently do #elif defined xxx because there isn't a #elifdef.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest OMAP randconfig build error

[Ohad Ben-Cohen]

On Wed, Feb 22, 2012 at 10:12 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> +#ifdef CONFIG_ARCH_OMAP2
> +struct omap_mbox *omap2_mboxes[] = {
> +       &mbox_dsp_info,
> +#ifdef CONFIG_SOC_OMAP2420
> +       &mbox_iva_info,
> +#endif
> +       NULL
> +};
>  #endif

Beautiful. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest OMAP randconfig build error

[Tony Lindgren]

* Ohad Ben-Cohen <ohad@wizery.com> [120222 11:51]:
> On Wed, Feb 22, 2012 at 10:12 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > +#ifdef CONFIG_ARCH_OMAP2
> > +struct omap_mbox *omap2_mboxes[] = {
> > +       &mbox_dsp_info,
> > +#ifdef CONFIG_SOC_OMAP2420
> > +       &mbox_iva_info,
> > +#endif
> > +       NULL
> > +};
> >  #endif
> 
> Beautiful. Thanks!

Care to post an updated patch for me to apply into fixes?

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest OMAP randconfig build error

[Ohad Ben-Cohen]

On Thu, Feb 23, 2012 at 12:56 AM, Tony Lindgren <tony@atomide.com> wrote:
> Care to post an updated patch for me to apply into fixes?

Coming right up!