linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
Date: Wed, 22 Feb 2012 15:07:15 -0800	[thread overview]
Message-ID: <20120222230714.GV18185@atomide.com> (raw)
In-Reply-To: <1329470706-29682-1-git-send-email-peter.ujfalusi@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [120217 00:54]:
> CCDN is the last common channel register in all OMAP4 versions. Use
> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
> doing what it supposed to do.

This is a bit unclear.. Which is not doing what is supposed to do?
DMA driver? Or one of the cpu_is_omap?

If this should be queued as a fix, then we need some kind of
description here what breaks.

Regards,

Tony
 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/mach-omap2/dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index a59a45a..b19d849 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
>  
>  	dma_stride		= OMAP2_DMA_STRIDE;
>  	dma_common_ch_start	= CSDP;
> -	if (cpu_is_omap3630() || cpu_is_omap4430())
> +	if (cpu_is_omap3630() || cpu_is_omap44xx())
>  		dma_common_ch_end = CCDN;
>  	else
>  		dma_common_ch_end = CCFN;
> -- 
> 1.7.8.4
> 

  reply	other threads:[~2012-02-22 23:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17  9:25 [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
2012-02-22 23:07 ` Tony Lindgren [this message]
2012-02-23  7:29   ` Peter Ujfalusi
2012-02-23  8:42     ` Shilimkar, Santosh
2012-02-23  9:04       ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120222230714.GV18185@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).