* [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
@ 2012-02-17 9:25 Peter Ujfalusi
2012-02-22 23:07 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2012-02-17 9:25 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap
CCDN is the last common channel register in all OMAP4 versions. Use
cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
doing what it supposed to do.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index a59a45a..b19d849 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch/arm/mach-omap2/dma.c
@@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
dma_stride = OMAP2_DMA_STRIDE;
dma_common_ch_start = CSDP;
- if (cpu_is_omap3630() || cpu_is_omap4430())
+ if (cpu_is_omap3630() || cpu_is_omap44xx())
dma_common_ch_end = CCDN;
else
dma_common_ch_end = CCFN;
--
1.7.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
2012-02-17 9:25 [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
@ 2012-02-22 23:07 ` Tony Lindgren
2012-02-23 7:29 ` Peter Ujfalusi
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2012-02-22 23:07 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: linux-omap
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120217 00:54]:
> CCDN is the last common channel register in all OMAP4 versions. Use
> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
> doing what it supposed to do.
This is a bit unclear.. Which is not doing what is supposed to do?
DMA driver? Or one of the cpu_is_omap?
If this should be queued as a fix, then we need some kind of
description here what breaks.
Regards,
Tony
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index a59a45a..b19d849 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
>
> dma_stride = OMAP2_DMA_STRIDE;
> dma_common_ch_start = CSDP;
> - if (cpu_is_omap3630() || cpu_is_omap4430())
> + if (cpu_is_omap3630() || cpu_is_omap44xx())
> dma_common_ch_end = CCDN;
> else
> dma_common_ch_end = CCFN;
> --
> 1.7.8.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
2012-02-22 23:07 ` Tony Lindgren
@ 2012-02-23 7:29 ` Peter Ujfalusi
2012-02-23 8:42 ` Shilimkar, Santosh
0 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2012-02-23 7:29 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap
Hi Tony,
On 02/23/2012 01:07 AM, Tony Lindgren wrote:
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [120217 00:54]:
>> CCDN is the last common channel register in all OMAP4 versions. Use
>> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
>> doing what it supposed to do.
>
> This is a bit unclear.. Which is not doing what is supposed to do?
> DMA driver? Or one of the cpu_is_omap?
The cpu_is_omap4430() returns 0 unconditionally. Because of this the
dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430).
> If this should be queued as a fix, then we need some kind of
> description here what breaks.
I will resend the patch with a better commit message. This is a bug for
sure, but I'm not sure how severe it is. At best we are not clearing the
registers between CCFN, and CCDN on OMAP4.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
2012-02-23 7:29 ` Peter Ujfalusi
@ 2012-02-23 8:42 ` Shilimkar, Santosh
2012-02-23 9:04 ` Peter Ujfalusi
0 siblings, 1 reply; 5+ messages in thread
From: Shilimkar, Santosh @ 2012-02-23 8:42 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: Tony Lindgren, linux-omap
On Thu, Feb 23, 2012 at 12:59 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> Hi Tony,
>
> On 02/23/2012 01:07 AM, Tony Lindgren wrote:
>> * Peter Ujfalusi <peter.ujfalusi@ti.com> [120217 00:54]:
>>> CCDN is the last common channel register in all OMAP4 versions. Use
>>> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
>>> doing what it supposed to do.
>>
>> This is a bit unclear.. Which is not doing what is supposed to do?
>> DMA driver? Or one of the cpu_is_omap?
>
> The cpu_is_omap4430() returns 0 unconditionally. Because of this the
> dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430).
>
>> If this should be queued as a fix, then we need some kind of
>> description here what breaks.
>
> I will resend the patch with a better commit message. This is a bug for
> sure, but I'm not sure how severe it is. At best we are not clearing the
> registers between CCFN, and CCDN on OMAP4.
>
The bug is not severe. Infact these registers are needed for
descriptor loading sDMA feature which never made it to mainline :)
So nothing should get impacted.
Regards
Santosh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
2012-02-23 8:42 ` Shilimkar, Santosh
@ 2012-02-23 9:04 ` Peter Ujfalusi
0 siblings, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2012-02-23 9:04 UTC (permalink / raw)
To: Shilimkar, Santosh; +Cc: Tony Lindgren, linux-omap
On 02/23/2012 10:42 AM, Shilimkar, Santosh wrote:
> The bug is not severe. Infact these registers are needed for
> descriptor loading sDMA feature which never made it to mainline :)
> So nothing should get impacted.
Yes, this is my understanding as well.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-23 9:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 9:25 [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
2012-02-22 23:07 ` Tony Lindgren
2012-02-23 7:29 ` Peter Ujfalusi
2012-02-23 8:42 ` Shilimkar, Santosh
2012-02-23 9:04 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).