From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
Subject: [PATCH 2/7] ARM: OMAP2+: Fix OMAP_HDQ_BASE build error
Date: Thu, 23 Feb 2012 16:54:07 -0800 [thread overview]
Message-ID: <20120224005406.16794.76522.stgit@kaulin.local> (raw)
In-Reply-To: <20120224005324.16794.73852.stgit@kaulin.local>
If CONFIG_SOC_OMAP3430 is not set and CONFIG_HDQ_MASTER_OMAP
is selected for w1 driver we get the following error:
arch/arm/mach-omap2/devices.c:662:13: error:
'OMAP_HDQ_BASE' undeclared here (not in a function)
Looks like OMAP_HDQ_BASE is valid for all omaps except
2420, so we can remove the ifdef and not register
the device on 2420.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/devices.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 283d11e..3ffefe2 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -654,9 +654,7 @@ void __init omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data)
/*-------------------------------------------------------------------------*/
#if defined(CONFIG_HDQ_MASTER_OMAP) || defined(CONFIG_HDQ_MASTER_OMAP_MODULE)
-#if defined(CONFIG_SOC_OMAP2430) || defined(CONFIG_SOC_OMAP3430)
#define OMAP_HDQ_BASE 0x480B2000
-#endif
static struct resource omap_hdq_resources[] = {
{
.start = OMAP_HDQ_BASE,
@@ -679,7 +677,10 @@ static struct platform_device omap_hdq_dev = {
};
static inline void omap_hdq_init(void)
{
- (void) platform_device_register(&omap_hdq_dev);
+ if (cpu_is_omap2420())
+ return;
+
+ platform_device_register(&omap_hdq_dev);
}
#else
static inline void omap_hdq_init(void) {}
next prev parent reply other threads:[~2012-02-24 0:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 0:54 [PATCH 0/7] More omap2+ randconfig fixes Tony Lindgren
2012-02-24 0:54 ` [PATCH 1/7] ARM: OMAP2+: Fix Kconfig dependencies for USB_ARCH_HAS_EHCI Tony Lindgren
2012-02-24 0:54 ` Tony Lindgren [this message]
2012-02-24 0:54 ` [PATCH 3/7] ARM: OMAP2+: Fix board_mux section type conflict when OMAP_MUX is not set Tony Lindgren
2012-02-24 0:54 ` [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected Tony Lindgren
2012-02-24 11:53 ` Sergei Shtylyov
2012-02-24 16:25 ` Tony Lindgren
2012-02-24 0:54 ` [PATCH 5/7] ARM: OMAP2+: Fix devexit for smartreflex when CONFIG_HOTPLUG is not set Tony Lindgren
2012-02-24 0:54 ` [PATCH 6/7] ARM: OMAP: Fix devexit for dma " Tony Lindgren
2012-02-24 0:54 ` [PATCH 7/7] ARM: OMAP2+: Fix multiple randconfig errors with SOC_OMAP and SOC_OMAP_NOOP Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224005406.16794.76522.stgit@kaulin.local \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).