* [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static
@ 2012-02-23 2:03 Nishanth Menon
2012-02-27 14:38 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Menon @ 2012-02-23 2:03 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-omap, lkml, Nishanth Menon
twl6030_irq_set_wake is not used anywhere else in the kernel
except as irq_chip.irq_set_wake. No reason for it to be exported.
Also fixes build warning:
drivers/mfd/twl6030-irq.c:230:5: warning: symbol 'twl6030_irq_set_wake' was not declared. Should it be static?
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/mfd/twl6030-irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index aa367a2..3c2cc00 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -236,7 +236,7 @@ static inline void activate_irq(int irq)
#endif
}
-int twl6030_irq_set_wake(struct irq_data *d, unsigned int on)
+static int twl6030_irq_set_wake(struct irq_data *d, unsigned int on)
{
if (on)
atomic_inc(&twl6030_wakeirqs);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static
2012-02-23 2:03 [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static Nishanth Menon
@ 2012-02-27 14:38 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-02-27 14:38 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-omap, lkml
Hi Nishan,
On Wed, Feb 22, 2012 at 08:03:59PM -0600, Nishanth Menon wrote:
> twl6030_irq_set_wake is not used anywhere else in the kernel
> except as irq_chip.irq_set_wake. No reason for it to be exported.
>
> Also fixes build warning:
> drivers/mfd/twl6030-irq.c:230:5: warning: symbol 'twl6030_irq_set_wake' was not declared. Should it be static?
>
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-27 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 2:03 [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static Nishanth Menon
2012-02-27 14:38 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).