linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-omap@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Latest OMAP4 build errors
Date: Tue, 28 Feb 2012 09:02:09 +0000	[thread overview]
Message-ID: <20120228090209.GC18045@n2100.arm.linux.org.uk> (raw)

This is from my tree plus arm-soc's for-next.  This build error was
introduced in arm-soc:

In file included from arch/arm/mach-omap2/iommu2.c:22:
arch/arm/plat-omap/include/plat/iommu.h: In function 'dev_to_omap_iommu':
arch/arm/plat-omap/include/plat/iommu.h:135: error: 'struct dev_archdata' has no member named 'iommu'
In file included from arch/arm/mach-omap2/omap-iommu.c:17:
arch/arm/plat-omap/include/plat/iommu.h: In function 'dev_to_omap_iommu':
arch/arm/plat-omap/include/plat/iommu.h:135: error: 'struct dev_archdata' has no member named 'iommu'

The problem appears to be that OMAP_IOMMU is selected without IOMMU_API.
This is done by:

config OMAP_REMOTEPROC
        tristate "OMAP remoteproc support"
        depends on ARCH_OMAP4
        select OMAP_IOMMU
...
        default m

This is wrong for two reasons:

1. It selects OMAP_IOMMU which may not have its dependencies satisfied.

warning: (OMAP_REMOTEPROC) selects OMAP_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && ARCH_OMAP)

2. It's a new feature.  It is experimental.  It should not default to 'm'

             reply	other threads:[~2012-02-28  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28  9:02 Russell King - ARM Linux [this message]
2012-02-28  9:51 ` Latest OMAP4 build errors Ohad Ben-Cohen
2012-02-28 10:01   ` Arnd Bergmann
2012-02-28 10:11     ` Ohad Ben-Cohen
2012-03-06 16:55       ` Russell King - ARM Linux
2012-03-06 17:01         ` Arnd Bergmann
2012-03-06 17:06           ` Ohad Ben-Cohen
2012-03-07 10:06           ` Russell King - ARM Linux
2012-03-07 17:10             ` Tony Lindgren
2012-03-07 22:18               ` Olof Johansson
2012-03-07 22:44                 ` Tony Lindgren
2012-03-07 23:43                   ` Russell King - ARM Linux
2012-03-08  3:34                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228090209.GC18045@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=arnd@arndb.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).