From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] cbus: Fix lines for Nokia 770
Date: Thu, 1 Mar 2012 16:02:19 -0800 [thread overview]
Message-ID: <20120302000219.GD18901@atomide.com> (raw)
In-Reply-To: <20120223084633.GB18463@legolas.emea.dhcp.ti.com>
* Felipe Balbi <balbi@ti.com> [120223 00:15]:
> Hi,
>
> On Wed, Feb 22, 2012 at 02:09:37PM -0800, Tony Lindgren wrote:
> > From 54c4785b8d274f8d282b4243945ae0b17edf4686 Mon Sep 17 00:00:00 2001
> > From: Tony Lindgren <tony@atomide.com>
> > Date: Wed, 22 Feb 2012 13:03:07 -0800
> > Subject: [PATCH] cbus: Fix lines for Nokia 770
> >
> > This makes retu and tahvo work again on Nokia 770 so it
> > stays running.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > ---
> >
> > I applied this into cbus branch as it seems to fix retu
> > watchdog for Nokia 770.
> >
> > --- a/arch/arm/mach-omap1/board-nokia770.c
> > +++ b/arch/arm/mach-omap1/board-nokia770.c
> > @@ -87,9 +87,9 @@ static struct platform_device nokia770_kp_device = {
> > #if defined(CONFIG_CBUS) || defined(CONFIG_CBUS_MODULE)
> >
> > static struct cbus_host_platform_data nokia770_cbus_data = {
> > - .clk_gpio = OMAP_MPUIO(11),
> > + .clk_gpio = OMAP_MPUIO(9),
> > .dat_gpio = OMAP_MPUIO(10),
> > - .sel_gpio = OMAP_MPUIO(9),
> > + .sel_gpio = OMAP_MPUIO(11),
> > };
> >
> > static struct platform_device nokia770_cbus_device = {
>
> Has this been wrong since the beginning ? Looking at commit d64193bd, I
> just moved whatever was on cbus.c to respective board-files.
Yes I think I dumped them from custom ATAGs quite a while ago,
but probably got them wrong way around at some point and have
been wondering ever since how come cbus does not seem to work
on 770 :)
Regards,
Tony
next prev parent reply other threads:[~2012-03-02 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 22:09 [PATCH] cbus: Fix lines for Nokia 770 Tony Lindgren
2012-02-23 8:46 ` Felipe Balbi
2012-03-02 0:02 ` Tony Lindgren [this message]
2012-03-02 9:22 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302000219.GD18901@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).