Re: [PATCH] cbus: Fix lines for Nokia 770

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On Thu, Mar 01, 2012 at 04:02:19PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [120223 00:15]:
> > Hi,
> > 
> > On Wed, Feb 22, 2012 at 02:09:37PM -0800, Tony Lindgren wrote:
> > > From 54c4785b8d274f8d282b4243945ae0b17edf4686 Mon Sep 17 00:00:00 2001
> > > From: Tony Lindgren <tony@atomide.com>
> > > Date: Wed, 22 Feb 2012 13:03:07 -0800
> > > Subject: [PATCH] cbus: Fix lines for Nokia 770
> > > 
> > > This makes retu and tahvo work again on Nokia 770 so it
> > > stays running.
> > > 
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > 
> > > ---
> > > 
> > > I applied this into cbus branch as it seems to fix retu
> > > watchdog for Nokia 770.
> > > 
> > > --- a/arch/arm/mach-omap1/board-nokia770.c
> > > +++ b/arch/arm/mach-omap1/board-nokia770.c
> > > @@ -87,9 +87,9 @@ static struct platform_device nokia770_kp_device = {
> > >  #if defined(CONFIG_CBUS) || defined(CONFIG_CBUS_MODULE)
> > >  
> > >  static struct cbus_host_platform_data nokia770_cbus_data = {
> > > -	.clk_gpio	= OMAP_MPUIO(11),
> > > +	.clk_gpio	= OMAP_MPUIO(9),
> > >  	.dat_gpio	= OMAP_MPUIO(10),
> > > -	.sel_gpio	= OMAP_MPUIO(9),
> > > +	.sel_gpio	= OMAP_MPUIO(11),
> > >  };
> > >  
> > >  static struct platform_device nokia770_cbus_device = {
> > 
> > Has this been wrong since the beginning ? Looking at commit d64193bd, I
> > just moved whatever was on cbus.c to respective board-files.
> 
> Yes I think I dumped them from custom ATAGs quite a while ago,
> but probably got them wrong way around at some point and have
> been wondering ever since how come cbus does not seem to work
> on 770 :)

I see... oh well, shit happens :-) Good catch btw :-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]