From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
Date: Wed, 7 Mar 2012 16:45:59 -0800 [thread overview]
Message-ID: <20120308004559.GN12083@atomide.com> (raw)
In-Reply-To: <20120307213209.GI12083@atomide.com>
* Tony Lindgren <tony@atomide.com> [120307 13:04]:
>
> Looks like this is needed for some .config files with
> current for-next
This is because of next/master commit 6c03438ed (kernel.h: doesn't
explicitly use bug.h, so don't include it). Will update the commit
message to say:
Otherwise we can get the following if bug.h is not included from kernel.h:
> arch/arm/mach-omap2/powerdomain-common.c:
> In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
> arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
> implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> --- a/arch/arm/mach-omap2/clkt_clksel.c
> +++ b/arch/arm/mach-omap2/clkt_clksel.c
> @@ -43,6 +43,7 @@
> #include <linux/errno.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> +#include <linux/bug.h>
>
> #include <plat/clock.h>
>
> --- a/arch/arm/mach-omap2/powerdomain-common.c
> +++ b/arch/arm/mach-omap2/powerdomain-common.c
> @@ -13,6 +13,7 @@
>
> #include <linux/errno.h>
> #include <linux/kernel.h>
> +#include <linux/bug.h>
> #include "pm.h"
> #include "cm.h"
> #include "cm-regbits-34xx.h"
> --- a/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
> +++ b/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/errno.h>
> #include <linux/delay.h>
> +#include <linux/bug.h>
>
> #include <plat/prcm.h>
>
> --- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
> +++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
> @@ -13,6 +13,7 @@
>
> #include <linux/kernel.h>
> #include <linux/init.h>
> +#include <linux/bug.h>
>
> #include <plat/cpu.h>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2012-03-08 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 21:32 [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h Tony Lindgren
2012-03-08 0:45 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308004559.GN12083@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).