From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators Date: Thu, 8 Mar 2012 13:08:26 -0800 Message-ID: <20120308210825.GY12083@atomide.com> References: <1330006564-13290-1-git-send-email-mporter@ti.com> <87wr74gis6.fsf@ti.com> <20120301204553.GA21841@legolas.emea.dhcp.ti.com> <87pqcqnc7u.fsf@ti.com> <87sjhkjj8m.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:11892 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876Ab2CHVIc (ORCPT ); Thu, 8 Mar 2012 16:08:32 -0500 Content-Disposition: inline In-Reply-To: <87sjhkjj8m.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Russ Dill , balbi@ti.com, Matt Porter , Russell King , Linux OMAP List , Linux ARM Kernel List , linux-kernel@vger.kernel.org * Kevin Hilman [120307 11:05]: > > > > I don't think the second smsc911x on the Overo, "smsc911x.1", would > > find it due to the dev_id. > > It's not about finding the second regulator. As stated in the > changelog, it's about the duplicate attempt to register the exact same > platform_device. > > Duplicate attempts to register the exact same platform_device cause > kobject to panic and give up[1]. So, any platform that calls > gpmc_smsc911x_init() twice (Overo and T35 in mainline) will panic on > boot. > > This patch fixes those platforms so they can boot. Yeah but I guess the second smsc911x instance still would not work, or am I missing something? Regards, Tony