From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v7 1/3] Documentation: common clk API Date: Sat, 17 Mar 2012 18:33:26 +0000 Message-ID: <201203171833.27068.arnd@arndb.de> References: <1331878280-2758-1-git-send-email-mturquette@linaro.org> <201203170905.33191.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: "Turquette, Mike" Cc: Nicolas Pitre , linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Saravana Kannan , Jeremy Kerr , Russell King , Magnus Damm , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Sascha Hauer , Rob Herring , Thomas Gleixner , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Walmsley , Linus Walleij , Mark Brown , Stephen Boyd , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On Saturday 17 March 2012, Turquette, Mike wrote: > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index 2eaf17e..a0a83de 100644 > > --- a/drivers/clk/Kconfig > > +++ b/drivers/clk/Kconfig > > @@ -12,7 +12,7 @@ config HAVE_MACH_CLKDEV > > > > menuconfig COMMON_CLK > > - bool "Common Clock Framework" > > + bool > > select HAVE_CLK_PREPARE > > ---help--- > > The common clock framework is a single definition of struct > > clk, useful across many platforms, as well as an > > Much like experimental I'm not sure how needed this change is. The > help section does say to leave it disabled by default, if unsure. If > you merge it I won't object but this might be fixing an imaginary > problem. Well, it doesn't have any consequences for real users, but it I think it does for randconfig builds, which we are trying to repair currently. Arnd