From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: "Munegowda, Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org,
govindraj.raja-l0cyMroinI0@public.gmane.org,
paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org,
b-cousson-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver
Date: Tue, 20 Mar 2012 11:59:16 +0200 [thread overview]
Message-ID: <20120320095914.GE9157@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAP05o4LkWpANqibBXsY-FbCTOsioUq4qPdA8k=Ct4HHGYfL4Ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
Hi,
On Tue, Mar 20, 2012 at 03:00:50PM +0530, Munegowda, Keshava wrote:
> >> +MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>");
> >> +MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
> >> +MODULE_LICENSE("GPL v2");
> >> +MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
> >> +
> >> +static int __init omap_usbtll_drvinit(void)
> >> +{
> >> + return platform_driver_probe(&usbtll_omap_driver, usbtll_omap_probe);
> >
> > please don't. Make sure you use platform_driver_register, instead.
>
>
> Here , omap_usbtll_drvinit is registered through fs_initcall call;
> this is required because, the TLL driver is required to initialized
> before the UHH ( usb host core) driver.
no issues with fs_initcall. The issue is with platform_driver_probe()
only.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-20 9:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:48 [PATCH 0/5 RESEND] ARM: OMAP: TLL driver implementation for USB host driver Keshava Munegowda
2012-03-19 6:48 ` [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver Keshava Munegowda
2012-03-19 6:48 ` [PATCH 2/5 RESEND] ARM: OMAP: USB: Build the USB HOST TLL omap device Keshava Munegowda
[not found] ` <1332139715-1495-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 3/5 RESEND] ARM: OMAP: USB: Remove TLL specific code Keshava Munegowda
[not found] ` <1332139715-1495-4-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 4/5 RESEND] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Keshava Munegowda
[not found] ` <1332139715-1495-5-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-19 6:48 ` [PATCH 5/5 RESEND] ARM: OMAP: change the USB TLL clocks device name Keshava Munegowda
2012-03-19 10:59 ` [PATCH 4/5 RESEND] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Sergei Shtylyov
2012-03-19 10:53 ` [PATCH 2/5 RESEND] ARM: OMAP: USB: Build the USB HOST TLL omap device Sergei Shtylyov
2012-03-19 9:41 ` [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver Shubhrajyoti
[not found] ` <4F66FF47.7000800-l0cyMroinI0@public.gmane.org>
2012-03-20 7:28 ` Munegowda, Keshava
[not found] ` <CAP05o4+A7AZ0SmMLgCfbBHs+zhsN-c2zM8caYe8M3-OC3YmZzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-20 8:52 ` Shubhrajyoti
2012-03-20 9:15 ` Munegowda, Keshava
2012-03-19 10:06 ` Felipe Balbi
2012-03-19 11:09 ` Sergei Shtylyov
[not found] ` <4F6713D8.3080206-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-03-20 7:25 ` Munegowda, Keshava
2012-03-20 9:30 ` Munegowda, Keshava
[not found] ` <CAP05o4LkWpANqibBXsY-FbCTOsioUq4qPdA8k=Ct4HHGYfL4Ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-20 9:59 ` Felipe Balbi [this message]
[not found] ` <20120320095914.GE9157-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-20 10:51 ` Munegowda, Keshava
2012-03-20 11:01 ` Felipe Balbi
2012-03-20 7:32 ` Munegowda, Keshava
2012-03-20 10:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320095914.GE9157@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=govindraj.raja-l0cyMroinI0@public.gmane.org \
--cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox