[PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[Kishon Vijay Abraham I]

Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619

pm_runtime_enable is being called after omap2430_musb_init. Hence
pm_runtime_get_sync in omap2430_musb_init does not have any effect (does
not enable clocks) resulting in a crash during register access. It is
fixed here.

Cc: stable@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
Tested MUSB in 4430SDP.
 drivers/usb/musb/omap2430.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 2ae0bb3..73bd5ed 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -452,14 +452,14 @@ static int __devinit omap2430_probe(struct platform_device *pdev)
 		goto err2;
 	}
 
+	pm_runtime_enable(&pdev->dev);
+
 	ret = platform_device_add(musb);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to register musb device\n");
 		goto err2;
 	}
 
-	pm_runtime_enable(&pdev->dev);
-
 	return 0;
 
 err2:
-- 
1.7.0.4

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[Greg KH]

On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote:
> Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
> Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619

<snip>

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[ABRAHAM, KISHON VIJAY]

Hi Greg,

On Thu, Mar 22, 2012 at 8:03 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote:
>> Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
>> Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619
>
> <snip>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>

I really couldn't get what I'm missing after reading the
Documentation/stable_kernel_rules.txt :-( Can you kindly let me know
what I'm missing here?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[Greg KH]

On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi Greg,
> 
> On Thu, Mar 22, 2012 at 8:03 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote:
> >> Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
> >> Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619
> >
> > <snip>
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> >
> > </formletter>
> 
> I really couldn't get what I'm missing after reading the
> Documentation/stable_kernel_rules.txt :-( Can you kindly let me know
> what I'm missing here?

Read the version of that file in the 3.3 kernel release, it should
explain what you are forgetting (hint, do you really want it applied to
the 2.4 kernel tree?)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[ABRAHAM, KISHON VIJAY]

Hi Greg,

On Fri, Mar 23, 2012 at 3:09 AM, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote:
>> Hi Greg,
>>
>> On Thu, Mar 22, 2012 at 8:03 PM, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
>> > On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote:
>> >> Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
>> >> Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619
>> >
>> > <snip>
>> >
>> > <formletter>
>> >
>> > This is not the correct way to submit patches for inclusion in the
>> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
>> > for how to do this properly.
>> >
>> > </formletter>
>>
>> I really couldn't get what I'm missing after reading the
>> Documentation/stable_kernel_rules.txt :-( Can you kindly let me know
>> what I'm missing here?
>
> Read the version of that file in the 3.3 kernel release, it should
> explain what you are forgetting (hint, do you really want it applied to
> the 2.4 kernel tree?)

I actually intended this patch to be back-ported to previous releases
which will have the issue. I'm not sure if it is right?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

[Greg KH]

On Fri, Mar 23, 2012 at 03:59:32AM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi Greg,
> 
> On Fri, Mar 23, 2012 at 3:09 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote:
> >> Hi Greg,
> >>
> >> On Thu, Mar 22, 2012 at 8:03 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> > On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote:
> >> >> Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
> >> >> Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619
> >> >
> >> > <snip>
> >> >
> >> > <formletter>
> >> >
> >> > This is not the correct way to submit patches for inclusion in the
> >> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> >> > for how to do this properly.
> >> >
> >> > </formletter>
> >>
> >> I really couldn't get what I'm missing after reading the
> >> Documentation/stable_kernel_rules.txt :-( Can you kindly let me know
> >> what I'm missing here?
> >
> > Read the version of that file in the 3.3 kernel release, it should
> > explain what you are forgetting (hint, do you really want it applied to
> > the 2.4 kernel tree?)
> 
> I actually intended this patch to be back-ported to previous releases
> which will have the issue. I'm not sure if it is right?

And what releases are those?

Hint, you need to tell us exactly what trees you want your patch applied
to, otherwise we will just guess, and usually, incorrectly.

Be specific.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html