From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 4/9] ARM: omap2+: fix building without i2c Date: Fri, 23 Mar 2012 10:22:17 -0700 Message-ID: <20120323172216.GB9859@atomide.com> References: <1332522836-29517-1-git-send-email-mathieu.poirier@linaro.org> <1332522836-29517-5-git-send-email-mathieu.poirier@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1332522836-29517-5-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: mathieu.poirier@linaro.org Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de List-Id: linux-omap@vger.kernel.org * mathieu.poirier@linaro.org [120323 10:16]: > From: Arnd Bergmann > > A trivial typo causes build breakage when I2C is disabled > and omap_i2c_reset is set to NULL on OMAP: > > omap_hwmod_44xx_data.c:2287:11: error: lvalue required as unary '&' operand > > Removing the '&' character solves this. We are now building in the omap_i2c_reset always, so this should be revalidated. We currently don't have NULL version of omap_i2c_reset any longer, so those '&' for functions are mostly cosmetic right now. Anyways, at least the commit message should be changed to be current. Regards, Tony