Re: [rtc-linux] [PATCH] RTC: twl6030: correct usage of static register while reading time

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 28 Mar 2012 16:34:01 -0500
Nishanth Menon <nm@ti.com> wrote:

> From: Konstantin Shlyakhovoy <x0155534@ti.com>
> 
> RTC stores time and date in several registers. Due to the fact that
> these registers can't be read instantaneously, there is a chance
> that reading from counting registers gives an error of one minute,
> one hour, one day, etc.
> 
> To address this issue, the RTC has hardware support to copy the
> RTC counting registers to static shadowed registers.
> The current implementation does not use this feature, and in a
> stress test,  we can reproduce this error at a rate of around
> two times per 300000 readings.
> 
> Fix the implementation to ensure that the right snapshot of time
> is captured.

hey, nice changelog!

Please cc me on rtc patches - I tend to be a bit slow reading the
rtc-linux list.

> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: linux-omap <linux-omap@vger.kernel.org>
> Acked-by: Mykola Oleksiienko <x0174904@ti.com>
> Acked-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
> Acked-by: Graeme Gregory <gg@slimlogic.co.uk>
> Acked-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Konstantin Shlyakhovoy <x0155534@ti.com>

I rewrote your acked-by to Signed-off-by, because you were on the
delivery path of the patch. Documentation/SubmittingPatches has details.

Is this OK?