* [GIT PULL] ARM: OMAP2+: resolve some sparse, cppcheck warnings
@ 2012-04-17 21:17 Paul Walmsley
2012-04-17 23:29 ` Paul Walmsley
0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2012-04-17 21:17 UTC (permalink / raw)
To: tony; +Cc: linux-omap, linux-arm-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Tony,
The following changes since commit 0034102808e0dbbf3a2394b82b1bb40b5778de9e:
Linux 3.4-rc2 (2012-04-07 18:30:41 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending tags/omap-cleanup-a-for-3.5
for you to fetch changes up to 0b93afd5d945a8c002f4d380a88b5d7a61c49289:
ARM: OMAP2+: clean up some cppcheck warnings (2012-04-13 06:34:32 -0600)
- ----------------------------------------------------------------
Resolve static analysis warnings generated by files in
arch/arm/mach-omap1, arch/arm/mach-omap2, and arch/arm/plat-omap.
Fixes all but one sparse warning and most of the useful
cppcheck warnings.
- ----------------------------------------------------------------
This series has been test-booted on 5912OSK, N800, CM-T3517, 3530ES3.0
Beagle, 37xx EVM, and 4430ES2 Panda. A few minor notes: N800 here is
not mounting MMC with or without this series, this is probably due to
a problem with my local N800 test setup which has recently changed.
Also CM-T3517 does not boot to userspace either with or without this
series.
Boot transcripts can be found at:
http://www.pwsan.com/omap/bootlogs/20120417/sparse_cppcheck_cleanup_3.5__0b93afd5d945a8c002f4d380a88b5d7a61c49289/
object size (delta in bytes from v3.4-rc2):
text data bss total kernel
-84 +24 0 -60 5912osk_testconfig/vmlinux
-100 -8 0 -108 n800_multi_omap2xxx/vmlinux
-68 -8 0 -76 n800_testconfig/vmlinux
-224 +56 -32 -200 omap1_defconfig/vmlinux
-148 +32 0 -116 omap2_4_testconfig/vmlinux
-212 0 0 -212 omap2plus_defconfig/vmlinux
-148 0 0 -148 omap2plus_no_pm/vmlinux
-152 0 0 -152 omap3_4_testconfig/vmlinux
-100 -8 0 -108 omap3_testconfig/vmlinux
-188 -24 0 -212 omap4_testconfig/vmlinux
Paul Walmsley (12):
ARM: OMAP2+: declare file-local functions as static
ARM: OMAP: add includes for missing prototypes
ARM: OMAP1: OCPI: move to mach-omap1/
ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus
ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse
ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings
ARM: OMAP: OCM RAM: use memset_io() when clearing SRAM
ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code
ARM: OMAP: USB: remove unnecessary sideways include
ARM: OMAP1: board files: deduplicate and clean some NAND-related code
ARM: OMAP1: DMTIMER: fix broken timer clock source selection
ARM: OMAP2+: clean up some cppcheck warnings
arch/arm/mach-omap1/Makefile | 13 +++++++++----
arch/arm/mach-omap1/ams-delta-fiq.c | 2 +-
arch/arm/mach-omap1/board-fsample.c | 16 +---------------
arch/arm/mach-omap1/board-h2.c | 17 +----------------
arch/arm/mach-omap1/board-h3.c | 16 +---------------
arch/arm/mach-omap1/board-nand.c | 37 +++++++++++++++++++++++++++++++++++++
arch/arm/mach-omap1/board-palmz71.c | 4 ++--
arch/arm/mach-omap1/board-perseus2.c | 16 +---------------
arch/arm/mach-omap1/clock.c | 3 +--
arch/arm/mach-omap1/common.h | 11 ++++++++++-
arch/arm/mach-omap1/fpga.c | 2 +-
arch/arm/mach-omap1/id.c | 2 ++
arch/arm/mach-omap1/io.c | 3 +--
arch/arm/mach-omap1/irq.c | 2 ++
arch/arm/mach-omap1/lcd_dma.c | 7 +------
arch/arm/{plat-omap => mach-omap1}/ocpi.c | 7 +++++--
arch/arm/mach-omap1/pm.c | 9 ++++-----
arch/arm/mach-omap1/reset.c | 2 ++
arch/arm/mach-omap1/timer.c | 7 +++----
arch/arm/mach-omap1/usb.c | 3 +++
arch/arm/mach-omap2/am35xx-emac.c | 37 +++++++++++++++++--------------------
arch/arm/mach-omap2/board-omap3evm.c | 8 ++++----
arch/arm/mach-omap2/board-omap4panda.c | 8 ++++----
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++--
arch/arm/mach-omap2/board-zoom-display.c | 1 +
arch/arm/mach-omap2/common.h | 2 --
arch/arm/mach-omap2/devices.c | 7 +++----
arch/arm/mach-omap2/gpio.c | 2 +-
arch/arm/mach-omap2/gpmc-onenand.c | 3 +--
arch/arm/mach-omap2/gpmc.c | 3 +--
arch/arm/mach-omap2/hwspinlock.c | 2 +-
arch/arm/mach-omap2/io.c | 1 +
arch/arm/mach-omap2/irq.c | 3 ++-
arch/arm/mach-omap2/mux.c | 2 +-
arch/arm/mach-omap2/omap-secure.c | 1 +
arch/arm/mach-omap2/omap-wakeupgen.c | 2 +-
arch/arm/mach-omap2/pm24xx.c | 3 ---
arch/arm/mach-omap2/pm34xx.c | 10 +++-------
arch/arm/mach-omap2/prm_common.c | 4 +++-
arch/arm/mach-omap2/serial.c | 2 +-
arch/arm/mach-omap2/usb-tusb6010.c | 2 +-
arch/arm/plat-omap/Makefile | 3 ---
arch/arm/plat-omap/common.c | 1 +
arch/arm/plat-omap/dma.c | 13 +++++++++++--
arch/arm/plat-omap/dmtimer.c | 3 ++-
arch/arm/plat-omap/include/plat/board.h | 2 ++
arch/arm/plat-omap/include/plat/common.h | 2 ++
arch/arm/plat-omap/include/plat/dma.h | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++--
arch/arm/plat-omap/omap_device.c | 2 --
arch/arm/plat-omap/sram.c | 4 ++--
arch/arm/plat-omap/usb.c | 4 ----
drivers/usb/host/ohci-omap.c | 5 +++--
53 files changed, 163 insertions(+), 167 deletions(-)
create mode 100644 arch/arm/mach-omap1/board-nand.c
rename arch/arm/{plat-omap => mach-omap1}/ocpi.c (93%)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJPjd2fAAoJEMePsQ0LvSpL1bwQAIQog3bnNUJlO/FQthjOb2+s
tKvvbjEgWtomVowvymYcf9DUxYS6kotWw33PqW5JfnFk7dy1/v5SkceCFpOU1F1P
24TOHznBOW8MGjbkPak52e30BEiIEHF4o17iEL+5C9z8TUjNj8KIC5WLt3Bis3q2
JaZbme3+IrFwV/JlKiCAojPRh9j0ofrm+W9l/Oo2377Dm69y14hiBtFuEOqKWIo2
XJwMytDDX6+UVNThCMGumBaPDyJFR/MIZxTu16eJAp+YUBMH0Q37vvfuHdmxWibC
l6G31BedtQqCulJJ49rIyJioBD10RjxKuZDF8B9zf60jzeI9CeSfDfy75vQtCBve
qYFKiBBum0xRunvoMrcJDnWjOJz6fB3gcY+vtRkgOSf9dRUyZ0Cp0dVWGFeMyKyG
l+T8YEFXsOcCIpdcRMlRoxoyiHkFjFAQANkYQZlVba8WjqZ/TmmLJj1ul7ZWo74z
TTIbsBnq9nBP6q8LXnpqzWBj8DyVkgbe6uyLcaaWaXZngnbw95FquUtJsk8cmOQN
+JpP8xSAuYogrzE6nR3MxIDeP/6ntACNwXu9ybVbUI3Gkq/wAC5P5QRMHHu3V+ff
yWDjwZYJFtCKRadQwY0OeVYX+hT/JYwr6q7GcOzLVKs2mMhveiarUJQrVW4yJPEJ
GHavtJN+KDqPSvYodnm+
=WpmP
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread* [GIT PULL] ARM: OMAP2+: resolve some sparse, cppcheck warnings
2012-04-17 21:17 [GIT PULL] ARM: OMAP2+: resolve some sparse, cppcheck warnings Paul Walmsley
@ 2012-04-17 23:29 ` Paul Walmsley
2012-04-18 17:20 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2012-04-17 23:29 UTC (permalink / raw)
To: tony; +Cc: linux-omap, linux-arm-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Tony,
The following changes since commit 0034102808e0dbbf3a2394b82b1bb40b5778de9e:
Linux 3.4-rc2 (2012-04-07 18:30:41 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending tags/omap-cleanup-a2-for-3.5
for you to fetch changes up to eeb3711b89d68e147e05e7b43a49ecc5009dc157:
ARM: OMAP2+: clean up some cppcheck warnings (2012-04-17 15:50:47 -0600)
- ----------------------------------------------------------------
Resolve static analysis warnings generated by files in
arch/arm/mach-omap1, arch/arm/mach-omap2, and arch/arm/plat-omap.
Fixes all but one sparse warning and most of the useful
cppcheck warnings (excepting the warnings generated by the
dmtimer integration code which is going up via 3.4-rc fixes)
- ----------------------------------------------------------------
This version drops the OMAP1 dmtimer integration patch ("ARM: OMAP1:
DMTIMER: fix broken timer clock source selection") that will go
upstream during 3.4-rc fixes. There are no other changes from the
previous branch.
The previous version of this series has been test-booted on 5912OSK,
N800, CM-T3517, 3530ES3.0 Beagle, 37xx EVM, and 4430ES2 Panda. A few
minor notes: N800 here is not mounting MMC with or without this
series, this is probably due to a problem with my local N800 test
setup which has recently changed. Also CM-T3517 does not boot to
userspace either with or without this series.
Boot transcripts of the previous version can be found at:
http://www.pwsan.com/omap/bootlogs/20120417/sparse_cppcheck_cleanup_3.5__0b93afd5d945a8c002f4d380a88b5d7a61c49289/
object size (delta in bytes from v3.4-rc2 (0034102808e0dbbf3a2394b82b1bb40b5778de9e)):
text data bss total kernel
-76 +24 0 -52 5912osk_testconfig/vmlinux
-100 -8 0 -108 n800_multi_omap2xxx/vmlinux
-68 -8 0 -76 n800_testconfig/vmlinux
-216 +56 -32 -192 omap1_defconfig/vmlinux
-148 +32 0 -116 omap2_4_testconfig/vmlinux
-212 0 0 -212 omap2plus_defconfig/vmlinux
-148 0 0 -148 omap2plus_no_pm/vmlinux
-152 0 0 -152 omap3_4_testconfig/vmlinux
-100 -8 0 -108 omap3_testconfig/vmlinux
-188 -24 0 -212 omap4_testconfig/vmlinux
Paul Walmsley (11):
ARM: OMAP2+: declare file-local functions as static
ARM: OMAP: add includes for missing prototypes
ARM: OMAP1: OCPI: move to mach-omap1/
ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus
ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse
ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings
ARM: OMAP: OCM RAM: use memset_io() when clearing SRAM
ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code
ARM: OMAP: USB: remove unnecessary sideways include
ARM: OMAP1: board files: deduplicate and clean some NAND-related code
ARM: OMAP2+: clean up some cppcheck warnings
arch/arm/mach-omap1/Makefile | 13 ++++++---
arch/arm/mach-omap1/ams-delta-fiq.c | 2 +-
arch/arm/mach-omap1/board-fsample.c | 16 +----------
arch/arm/mach-omap1/board-h2.c | 17 +-----------
arch/arm/mach-omap1/board-h3.c | 16 +----------
arch/arm/mach-omap1/board-nand.c | 37 ++++++++++++++++++++++++++
arch/arm/mach-omap1/board-palmz71.c | 4 +--
arch/arm/mach-omap1/board-perseus2.c | 16 +----------
arch/arm/mach-omap1/clock.c | 3 +--
arch/arm/mach-omap1/common.h | 11 +++++++-
arch/arm/mach-omap1/fpga.c | 2 +-
arch/arm/mach-omap1/id.c | 2 ++
arch/arm/mach-omap1/io.c | 3 +--
arch/arm/mach-omap1/irq.c | 2 ++
arch/arm/mach-omap1/lcd_dma.c | 7 +----
arch/arm/{plat-omap => mach-omap1}/ocpi.c | 7 +++--
arch/arm/mach-omap1/pm.c | 9 +++----
arch/arm/mach-omap1/reset.c | 2 ++
arch/arm/mach-omap1/timer.c | 3 +--
arch/arm/mach-omap1/usb.c | 3 +++
arch/arm/mach-omap2/am35xx-emac.c | 37 ++++++++++++--------------
arch/arm/mach-omap2/board-omap3evm.c | 8 +++---
arch/arm/mach-omap2/board-omap4panda.c | 8 +++---
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 +--
arch/arm/mach-omap2/board-zoom-display.c | 1 +
arch/arm/mach-omap2/common.h | 2 --
arch/arm/mach-omap2/devices.c | 7 +++--
arch/arm/mach-omap2/gpio.c | 2 +-
arch/arm/mach-omap2/gpmc-onenand.c | 3 +--
arch/arm/mach-omap2/gpmc.c | 3 +--
arch/arm/mach-omap2/hwspinlock.c | 2 +-
arch/arm/mach-omap2/io.c | 1 +
arch/arm/mach-omap2/irq.c | 3 ++-
arch/arm/mach-omap2/mux.c | 2 +-
arch/arm/mach-omap2/omap-secure.c | 1 +
arch/arm/mach-omap2/omap-wakeupgen.c | 2 +-
arch/arm/mach-omap2/pm24xx.c | 3 ---
arch/arm/mach-omap2/pm34xx.c | 10 +++----
arch/arm/mach-omap2/prm_common.c | 4 ++-
arch/arm/mach-omap2/serial.c | 2 +-
arch/arm/mach-omap2/usb-tusb6010.c | 2 +-
arch/arm/plat-omap/Makefile | 3 ---
arch/arm/plat-omap/common.c | 1 +
arch/arm/plat-omap/dma.c | 13 +++++++--
arch/arm/plat-omap/dmtimer.c | 3 ++-
arch/arm/plat-omap/include/plat/board.h | 2 ++
arch/arm/plat-omap/include/plat/common.h | 2 ++
arch/arm/plat-omap/include/plat/dma.h | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 4 +--
arch/arm/plat-omap/omap_device.c | 2 --
arch/arm/plat-omap/sram.c | 4 +--
arch/arm/plat-omap/usb.c | 4 ---
drivers/usb/host/ohci-omap.c | 5 ++--
53 files changed, 161 insertions(+), 165 deletions(-)
create mode 100644 arch/arm/mach-omap1/board-nand.c
rename arch/arm/{plat-omap => mach-omap1}/ocpi.c (93%)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIbBAEBAgAGBQJPjfzDAAoJEMePsQ0LvSpL6mUP+ImtiaS78Of2vl3lTt6RodRO
CjbCIa3xK7Db3iIPo2iJJgHxYYGyyAtDrCxZShLyuYg5ivtxGSBZ1HDsWNL/uBmn
a8teYFXJd2S4JZedsO8pIRwo2n7YKtHlI6HW7gyz/HrZrlYysixdAEHDwPCaDzA3
Er2jpVBx20NpQuArUexz3Y/gRRTtNpL6KHaj7RLSr2HCBrUGjHGZxdalSmIaL7x8
otMNQFcVNl4vOIHZY4ThzPrTExQuMhxssi1pBJtscx7Q2Q8CDUix8cluysUSdXX9
hQps385yFRLVe5NKTXanWwP4fxeuRql0IcJ60YLX5BxsXgd7768lAWWMM7IiHsZ4
sR1jGlwDR/RzxQxSyaCO/9kUg+6LH0CZXdFQHVZpydTdp74ShzT7V74DpPwZkdvo
44jlANmCYWRMeVs82IgP2qjpU86SUT5DlR4q523PudBKYZyZCw9OqML5cG4hVN4m
YBG0TWfebhJQ8Xm1Bb6tFZy33NG+EfJ+F+IQ0M0tddV7aNP0lOiWysDHKlgRMuyZ
IiZR16IVghFwEcMxFejLl5WfEkQ2Eu4Bax0tU0iEDgOlMkZaCX4+qjmkPDhqrAhK
DQim6gNM6Lue7DkZiDfqFbKEvYrV42cvf4ggEzuT1pQh3csjYrnWomZUUrm9YJge
xMukLIN3k5ge5AI15i4=
=amuA
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GIT PULL] ARM: OMAP2+: resolve some sparse, cppcheck warnings
2012-04-17 23:29 ` Paul Walmsley
@ 2012-04-18 17:20 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2012-04-18 17:20 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap, linux-arm-kernel
* Paul Walmsley <paul@pwsan.com> [120417 16:33]:
> Hi Tony,
>
> The following changes since commit 0034102808e0dbbf3a2394b82b1bb40b5778de9e:
>
> Linux 3.4-rc2 (2012-04-07 18:30:41 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending tags/omap-cleanup-a2-for-3.5
>
> for you to fetch changes up to eeb3711b89d68e147e05e7b43a49ecc5009dc157:
>
> ARM: OMAP2+: clean up some cppcheck warnings (2012-04-17 15:50:47 -0600)
>
> ----------------------------------------------------------------
> Resolve static analysis warnings generated by files in
> arch/arm/mach-omap1, arch/arm/mach-omap2, and arch/arm/plat-omap.
> Fixes all but one sparse warning and most of the useful
> cppcheck warnings (excepting the warnings generated by the
> dmtimer integration code which is going up via 3.4-rc fixes)
>
> ----------------------------------------------------------------
>
> This version drops the OMAP1 dmtimer integration patch ("ARM: OMAP1:
> DMTIMER: fix broken timer clock source selection") that will go
> upstream during 3.4-rc fixes. There are no other changes from the
> previous branch.
Thanks, pulled now into cleanup-sparse and merged into linux-omap
master for some testing.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-18 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 21:17 [GIT PULL] ARM: OMAP2+: resolve some sparse, cppcheck warnings Paul Walmsley
2012-04-17 23:29 ` Paul Walmsley
2012-04-18 17:20 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).