From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default Date: Wed, 18 Apr 2012 20:08:33 +0100 Message-ID: <20120418200833.24ef25ff@pyramind.ukuu.org.uk> References: <1334579407-16970-1-git-send-email-govindraj.raja@ti.com> <87vckyq6ti.fsf@ti.com> <87mx69nms2.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:54424 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591Ab2DRTGP (ORCPT ); Wed, 18 Apr 2012 15:06:15 -0400 In-Reply-To: <87mx69nms2.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: "Raja, Govindraj" , linux-omap@vger.kernel.org, Paul Walmsley , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org > The point is that wakeups should be enabled whenever driver is in use, > and disabled when the driver is not in use. Which is the tty_port methods for initialisation and shutdown, which are mutex protected against each other and hang up. Not sure how the uart layer glue exposes that. Alan